From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Keith Busch <keith.busch@intel.com>
Cc: linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
Sinan Kaya <okaya@codeaurora.org>,
Bjorn Helgaas <bhelgaas@google.com>,
"Alex G ." <mr.nuke.me@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] nvme/pci: Sync controller reset for AER slot_reset
Date: Fri, 11 May 2018 16:54:11 -0400 [thread overview]
Message-ID: <yq1in7tq5fw.fsf@oracle.com> (raw)
In-Reply-To: <20180510160113.4432-1-keith.busch@intel.com> (Keith Busch's message of "Thu, 10 May 2018 10:01:13 -0600")
Keith,
> AER handling expects a successful return from slot_reset means the
> driver made the device functional again. The nvme driver had been using
> an asynchronous reset to recover the device, so the device
> may still be initializing after control is returned to the
> AER handler. This creates problems for subsequent event handling,
> causing the initializion to fail.
>
> This patch fixes that by syncing the controller reset before returning
> to the AER driver, and reporting the true state of the reset.
LGTM.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-05-11 20:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 16:01 [PATCH] nvme/pci: Sync controller reset for AER slot_reset Keith Busch
2018-05-10 18:56 ` Alex G.
2018-05-10 19:14 ` Keith Busch
2018-05-10 19:20 ` Alex G.
2018-05-11 14:18 ` Alex G.
2018-05-12 9:27 ` Ming Lei
2018-05-11 6:38 ` Christoph Hellwig
2018-05-11 20:54 ` Martin K. Petersen [this message]
2018-05-11 21:09 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1in7tq5fw.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=bhelgaas@google.com \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-nvme@lists.infradead.org \
--cc=mr.nuke.me@gmail.com \
--cc=okaya@codeaurora.org \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).