From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD94CC43381 for ; Tue, 26 Feb 2019 14:40:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9AAEF2173C for ; Tue, 26 Feb 2019 14:40:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="op9eeef3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727446AbfBZOkm (ORCPT ); Tue, 26 Feb 2019 09:40:42 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:59206 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726965AbfBZOkl (ORCPT ); Tue, 26 Feb 2019 09:40:41 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1QEYOgm134144; Tue, 26 Feb 2019 14:40:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=p8v+4bk9/l6byI5qx+fHq704mW7aU+01btzuNDVWxNE=; b=op9eeef31P1CBYTT1QCNSr3fapXYuyGRlcd6FCd1KsznSQVP/L7iBy/eBVn6KmHtjtsA 7ZA3XL4KpF5noX7AijrN8w/GtDSrnYPoYMHd/O6/bub7N903Irgv6+EKrgTXrMDZ2JrR AvP5+TIVwTDnH6lFhJsLY05hOyJyFyYyiPLl/0CN1R/heafP/pAP/D1Ti7RKYoIdCe8u M6XgvzE7w/9jihar3Ri8NYRsSNKktTcm/RwlR/71n2T0f3ojbEvIhFyMl4qCAvl5RKXG LpVkYZ7UdnqnP1cGQTC2gK45BjM8QvydZRqxfgT4KSgHnr8frVlnzwgp1Stl1lT+63b4 Ew== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2130.oracle.com with ESMTP id 2qtwku4ypg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Feb 2019 14:40:28 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x1QEeRcJ027957 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Feb 2019 14:40:27 GMT Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x1QEeQJV008171; Tue, 26 Feb 2019 14:40:26 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 26 Feb 2019 06:40:26 -0800 To: Christoph Hellwig Cc: Hannes Reinecke , Sreekanth Reddy , linux-scsi , Sathya Prakash , Suganath Prabu Subramani , stable@vger.kernel.org Subject: Re: [PATCH v1] mpt3sas: Use driver scsi lookup to track outstanding IOs From: "Martin K. Petersen" Organization: Oracle Corporation References: <1550751105-46065-1-git-send-email-sreekanth.reddy@broadcom.com> <61a8f703-3f20-b777-08b9-54ae34dffa59@suse.de> <0dfb09ca-8723-3a3c-a6a8-c643856c57e3@suse.de> <20190226143313.GA23865@infradead.org> Date: Tue, 26 Feb 2019 09:40:24 -0500 In-Reply-To: <20190226143313.GA23865@infradead.org> (Christoph Hellwig's message of "Tue, 26 Feb 2019 06:33:13 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9178 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=866 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902260107 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org > While this is better than the driver private tracking we really should > not have to iterate all outstanding command, because if we have any > there is a bug we need to fix in the higher layers instead of working > around it in the drivers. I agree completely. -- Martin K. Petersen Oracle Linux Engineering