From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2120.oracle.com ([156.151.31.85]:33116 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727940AbeLFERb (ORCPT ); Wed, 5 Dec 2018 23:17:31 -0500 To: Bart Van Assche Cc: "Martin K. Petersen" , linux-scsi@vger.kernel.org, john.garry@huawei.com, stable@vger.kernel.org Subject: Re: [PATCH] scsi: t10-pi: Return correct ref tag when queue has no integrity profile From: "Martin K. Petersen" References: <20181205023110.20162-1-martin.petersen@oracle.com> <2abe64a3-d54b-4cbb-bc56-1796e62fd0f9@acm.org> <4f705b13-84aa-b8bd-9c92-ab619a653f9c@acm.org> Date: Wed, 05 Dec 2018 23:17:14 -0500 In-Reply-To: <4f705b13-84aa-b8bd-9c92-ab619a653f9c@acm.org> (Bart Van Assche's message of "Wed, 5 Dec 2018 07:00:58 -0800") Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: stable-owner@vger.kernel.org List-ID: Bart, > Had you considered to use lower_32_bits() instead of "0xffffffff"? > That would to avoid that reviewers have to count the 'f'-s to verify > correctness of t10_pi_ref_tag(). I hadn't. I guess I tend to think of lower_32_bits() as something you do to pointers, not to block numbers. -- Martin K. Petersen Oracle Linux Engineering