From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1561C43381 for ; Thu, 28 Mar 2019 01:19:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 683902070B for ; Thu, 28 Mar 2019 01:19:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="LM+CMEAW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726171AbfC1BTE (ORCPT ); Wed, 27 Mar 2019 21:19:04 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:53870 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbfC1BTE (ORCPT ); Wed, 27 Mar 2019 21:19:04 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x2S14iVx014766; Thu, 28 Mar 2019 01:18:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=0GNElROyh8aFz/V8SVO24s5arNxbSqkVpmAblM0uQhg=; b=LM+CMEAWsFuGjU2MPKzpFgCfUQPuFFTqIhf5zE40mJqOv3+4GCuN1dDnKmvahtmOujVH H+fJ8bopnOHuORFlXmp5nfh+/ysspRw0ezmvKpYjf4NH4WI3g0pIvCVvXHG7kiggMVwF rB3p2FggvaRdplTr9h9D2yr2N5ZZADHh2W8UFzKC+lEmM/KhorTpHqqor9Vl8U4Icu0D LY5IYAMcFBn9Wi59mJsXqN9Mk5B/PkZVBEsd1zWNva3V5gdzyDOYNEhbeh3q/UPw2xxZ FG8EVqfemrk0pT+QDJEes3Jgb7GqC0SBTC7Re2O6ReTgi3cF+M5L2DhvAEY9aA0+yW3I jg== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2re6djkud6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Mar 2019 01:18:49 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x2S1IbsA014605 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Mar 2019 01:18:38 GMT Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x2S1IbVk018102; Thu, 28 Mar 2019 01:18:37 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 27 Mar 2019 18:18:37 -0700 To: Bart Van Assche Cc: "Martin K . Petersen" , "James E . J . Bottomley" , linux-scsi@vger.kernel.org, Christoph Hellwig , Ming Lei , Hannes Reinecke , Johannes Thumshirn , Jason Yan , stable@vger.kernel.org Subject: Re: [PATCH] sd: Fix a race between closing an sd device and sd I/O From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190325170146.184414-1-bvanassche@acm.org> Date: Wed, 27 Mar 2019 21:18:34 -0400 In-Reply-To: <20190325170146.184414-1-bvanassche@acm.org> (Bart Van Assche's message of "Mon, 25 Mar 2019 10:01:46 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9208 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=682 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903280007 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Bart, > The scsi_end_request() function calls scsi_cmd_to_driver() indirectly > and hence needs the disk->private_data pointer. Avoid that that > pointer is cleared before all affected I/O requests have > finished. This patch avoids that the following crash occurs: Applied to 5.1/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering