From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Ranjan Kumar <ranjan.kumar@broadcom.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, sathya.prakash@broadcom.com,
sreekanth.reddy@broadcom.com, stable@vger.kernel.org
Subject: Re: [PATCH v3 1/2] Perform additional retries if Doorbell read returns 0
Date: Mon, 07 Aug 2023 22:37:09 -0400 [thread overview]
Message-ID: <yq1sf8ujmf2.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <CAMFBP8MS0hwd9-bfVrPi8yTB3Es-w7ugHwEMyxtb8R-mj8PPCg@mail.gmail.com> (Ranjan Kumar's message of "Thu, 3 Aug 2023 13:46:12 +0530")
Hi Ranjan!
>> This HW bug impacts only a few registers. However, for code
>> simplicity, we added retry logic(of 3 retries count) for all
>> registers exposed to the driver.
> Now the recommendation is:
> - Increase retry count from 3 to 30 for only impacted registers.
> - We also do not want to reduce the retries from 3 to 1 for
> non-impacted registers to avoid any regression.
>
> Hence, this patch retries upto 30 times for impacted registers and 3
> times for non-impacted registers.
What is the adverse affect is of having a loop iterator of 30 if the
non-impacted registers always return a non-zero value after 1 to 3
attempts?
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2023-08-08 2:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230726112527.14987-1-ranjan.kumar@broadcom.com>
2023-07-26 11:25 ` [PATCH v3 1/2] Perform additional retries if Doorbell read returns 0 Ranjan Kumar
2023-07-31 17:54 ` Martin K. Petersen
2023-08-03 8:16 ` Ranjan Kumar
2023-08-08 2:37 ` Martin K. Petersen [this message]
2023-08-08 7:12 ` Ranjan Kumar
2023-08-09 1:25 ` Martin K. Petersen
2023-08-09 8:23 ` David Laight
2023-08-10 5:44 ` Ranjan Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1sf8ujmf2.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=ranjan.kumar@broadcom.com \
--cc=sathya.prakash@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox