From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp1040.oracle.com ([156.151.31.81]:31830 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752072AbdAYX2n (ORCPT ); Wed, 25 Jan 2017 18:28:43 -0500 To: Bart Van Assche Cc: "Martin K . Petersen" , , Michael Hernandez , Himanshu Madhani , Christoph Hellwig , Subject: Re: [PATCH 1/2] qla2xxx: Fix a recently introduced memory leak From: "Martin K. Petersen" References: <20170123163446.9227-1-bart.vanassche@sandisk.com> <20170123163446.9227-2-bart.vanassche@sandisk.com> Date: Wed, 25 Jan 2017 18:28:20 -0500 In-Reply-To: <20170123163446.9227-2-bart.vanassche@sandisk.com> (Bart Van Assche's message of "Mon, 23 Jan 2017 08:34:45 -0800") Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: stable-owner@vger.kernel.org List-ID: >>>>> "Bart" == Bart Van Assche writes: Bart> qla2x00_probe_one() allocates IRQs before it initializes rsp_q_map Bart> so IRQs must be freed even if rsp_q_map allocation did not occur. Bart> This was detected by kmemleak. I queued this one yesterday but was waiting for a resolution on patch 2... -- Martin K. Petersen Oracle Linux Engineering