[PATCH v2 1/1] scsi: ufs: core: Fix the HIGH/LOW_TEMP Bit Definitions

[PATCH v2 1/1] scsi: ufs: core: Fix the HIGH/LOW_TEMP Bit Definitions

[Bao D. Nguyen]

According to the UFS Device Specification, the dExtendedUFSFeaturesSupport
defines the support for TOO_HIGH_TEMPERATURE as bit[4] and the
TOO_LOW_TEMPERATURE as bit[5]. Correct the code to match with
the UFS device specification definition.

Fixes: e88e2d322 ("scsi: ufs: core: Probe for temperature notification support")
Cc: stable@vger.kernel.org
Signed-off-by: Bao D. Nguyen <quic_nguyenb@quicinc.com>
Reviewed-by: Avri Altman <Avri.Altman@wdc.com>
---
 include/ufs/ufs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/ufs/ufs.h b/include/ufs/ufs.h
index e594abe..f0c6111 100644
--- a/include/ufs/ufs.h
+++ b/include/ufs/ufs.h
@@ -386,8 +386,8 @@ enum {
 
 /* Possible values for dExtendedUFSFeaturesSupport */
 enum {
-	UFS_DEV_LOW_TEMP_NOTIF		= BIT(4),
-	UFS_DEV_HIGH_TEMP_NOTIF		= BIT(5),
+	UFS_DEV_HIGH_TEMP_NOTIF		= BIT(4),
+	UFS_DEV_LOW_TEMP_NOTIF		= BIT(5),
 	UFS_DEV_EXT_TEMP_NOTIF		= BIT(6),
 	UFS_DEV_HPB_SUPPORT		= BIT(7),
 	UFS_DEV_WRITE_BOOSTER_SUP	= BIT(8),
-- 
2.7.4

Re: [PATCH v2 1/1] scsi: ufs: core: Fix the HIGH/LOW_TEMP Bit Definitions

[Peter Wang (王信友)]

On Mon, 2025-01-13 at 10:32 -0800, Bao D. Nguyen wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> According to the UFS Device Specification, the
> dExtendedUFSFeaturesSupport
> defines the support for TOO_HIGH_TEMPERATURE as bit[4] and the
> TOO_LOW_TEMPERATURE as bit[5]. Correct the code to match with
> the UFS device specification definition.
> 
> Fixes: e88e2d322 ("scsi: ufs: core: Probe for temperature
> notification support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Bao D. Nguyen <quic_nguyenb@quicinc.com>
> Reviewed-by: Avri Altman <Avri.Altman@wdc.com>
> ---
>  include/ufs/ufs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/ufs/ufs.h b/include/ufs/ufs.h
> index e594abe..f0c6111 100644
> --- a/include/ufs/ufs.h
> +++ b/include/ufs/ufs.h
> @@ -386,8 +386,8 @@ enum {
> 
>  /* Possible values for dExtendedUFSFeaturesSupport */
>  enum {
> -       UFS_DEV_LOW_TEMP_NOTIF          = BIT(4),
> -       UFS_DEV_HIGH_TEMP_NOTIF         = BIT(5),
> +       UFS_DEV_HIGH_TEMP_NOTIF         = BIT(4),
> +       UFS_DEV_LOW_TEMP_NOTIF          = BIT(5),
>         UFS_DEV_EXT_TEMP_NOTIF          = BIT(6),
>         UFS_DEV_HPB_SUPPORT             = BIT(7),
>         UFS_DEV_WRITE_BOOSTER_SUP       = BIT(8),
> --
> 2.7.4
> 

Hi Bao,

Thanks for fix this bug.

Reviewed-by: Peter Wang <peter.wang@mediatek.com>

Re: [PATCH v2 1/1] scsi: ufs: core: Fix the HIGH/LOW_TEMP Bit Definitions

[Manivannan Sadhasivam]

On Mon, Jan 13, 2025 at 10:32:07AM -0800, Bao D. Nguyen wrote:
> According to the UFS Device Specification, the dExtendedUFSFeaturesSupport
> defines the support for TOO_HIGH_TEMPERATURE as bit[4] and the
> TOO_LOW_TEMPERATURE as bit[5]. Correct the code to match with
> the UFS device specification definition.
> 
> Fixes: e88e2d322 ("scsi: ufs: core: Probe for temperature notification support")

Fixes commit SHA should be 12 characters:

Fixes: e88e2d32200a ("scsi: ufs: core: Probe for temperature notification support")

- Mani

> Cc: stable@vger.kernel.org
> Signed-off-by: Bao D. Nguyen <quic_nguyenb@quicinc.com>
> Reviewed-by: Avri Altman <Avri.Altman@wdc.com>
> ---
>  include/ufs/ufs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/ufs/ufs.h b/include/ufs/ufs.h
> index e594abe..f0c6111 100644
> --- a/include/ufs/ufs.h
> +++ b/include/ufs/ufs.h
> @@ -386,8 +386,8 @@ enum {
>  
>  /* Possible values for dExtendedUFSFeaturesSupport */
>  enum {
> -	UFS_DEV_LOW_TEMP_NOTIF		= BIT(4),
> -	UFS_DEV_HIGH_TEMP_NOTIF		= BIT(5),
> +	UFS_DEV_HIGH_TEMP_NOTIF		= BIT(4),
> +	UFS_DEV_LOW_TEMP_NOTIF		= BIT(5),
>  	UFS_DEV_EXT_TEMP_NOTIF		= BIT(6),
>  	UFS_DEV_HPB_SUPPORT		= BIT(7),
>  	UFS_DEV_WRITE_BOOSTER_SUP	= BIT(8),
> -- 
> 2.7.4
> 

-- 
மணிவண்ணன் சதாசிவம்

Re: [PATCH v2 1/1] scsi: ufs: core: Fix the HIGH/LOW_TEMP Bit Definitions

[Martin K. Petersen]

Bao,

> According to the UFS Device Specification, the
> dExtendedUFSFeaturesSupport defines the support for
> TOO_HIGH_TEMPERATURE as bit[4] and the TOO_LOW_TEMPERATURE as bit[5].
> Correct the code to match with the UFS device specification
> definition.

Applied to 6.14/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH v2 1/1] scsi: ufs: core: Fix the HIGH/LOW_TEMP Bit Definitions

[Martin K. Petersen]

On Mon, 13 Jan 2025 10:32:07 -0800, Bao D. Nguyen wrote:

> According to the UFS Device Specification, the dExtendedUFSFeaturesSupport
> defines the support for TOO_HIGH_TEMPERATURE as bit[4] and the
> TOO_LOW_TEMPERATURE as bit[5]. Correct the code to match with
> the UFS device specification definition.
> 
> 

Applied to 6.14/scsi-fixes, thanks!

[1/1] scsi: ufs: core: Fix the HIGH/LOW_TEMP Bit Definitions
      https://git.kernel.org/mkp/scsi/c/1b3e2d4ec0c5

-- 
Martin K. Petersen	Oracle Linux Engineering