From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Salvatore Bonaccorso <carnil@debian.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
stable <stable@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sasha Levin <sashal@kernel.org>, Martin Wilck <mwilck@suse.com>,
Christoph Hellwig <hch@infradead.org>,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
"Linux regression tracking (Thorsten Leemhuis)"
<regressions@leemhuis.info>
Subject: Re: Please apply commit 06e472acf964 ("scsi: mpt3sas: Remove usage of dma_get_required_mask() API") to stable series
Date: Wed, 08 Mar 2023 14:05:01 -0500 [thread overview]
Message-ID: <yq1wn3rgj7a.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <ZAi4k/09acWV0wRZ@eldamar.lan> (Salvatore Bonaccorso's message of "Wed, 8 Mar 2023 17:32:19 +0100")
Salvatore,
> So I believe the right thing would be to revert first in the stable
> series where it was applied (5.10.y, 5.15.y) the commit e0e0747de0ea
> ("scsi: mpt3sas: Fix return value check of dma_get_required_mask()")
> and then on top of this revert apply the patches:
>
> 9df650963bf6 ("scsi: mpt3sas: Don't change DMA mask while reallocating pools")
> 1a2dcbdde82e ("scsi: mpt3sas: re-do lost mpt3sas DMA mask fix")
> 06e472acf964 ("scsi: mpt3sas: Remove usage of dma_get_required_mask() API")
>
> Attached mbox file implements this.
>
> Does that looks now good for resolving the regression?
Yes, that's one way to resolve it.
At a quick glance your mbox looks fine. Best way to validate would be to
compare the resulting _base_config_dma_addressing() function between
your tree and upstream. I don't believe we have had additional changes
here so there should be no delta.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2023-03-08 19:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-04 9:52 Please apply commit 06e472acf964 ("scsi: mpt3sas: Remove usage of dma_get_required_mask() API") to stable series Salvatore Bonaccorso
2023-03-06 7:21 ` Greg Kroah-Hartman
2023-03-06 20:53 ` Salvatore Bonaccorso
2023-03-07 1:16 ` Martin K. Petersen
2023-03-08 16:32 ` Salvatore Bonaccorso
2023-03-08 18:06 ` Martin Wilck
2023-03-08 19:33 ` Salvatore Bonaccorso
2023-03-10 12:53 ` Greg Kroah-Hartman
2023-03-08 19:05 ` Martin K. Petersen [this message]
2023-03-09 9:45 ` Salvatore Bonaccorso
2023-03-09 15:51 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1wn3rgj7a.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=carnil@debian.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=mwilck@suse.com \
--cc=regressions@leemhuis.info \
--cc=sashal@kernel.org \
--cc=sreekanth.reddy@broadcom.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox