* Re: [PATCH] lpfc: remove left-over BUILD_NVME defines
[not found] ` <yq1eezake0f.fsf@oracle.com>
@ 2019-10-18 16:36 ` James Smart
2019-10-18 21:22 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: James Smart @ 2019-10-18 16:36 UTC (permalink / raw)
To: Martin K. Petersen, Hannes Reinecke
Cc: Christoph Hellwig, James Bottomley, linux-scsi, Martin George,
Daniel Wagner, Hannes Reinecke, James Smart, stable
On 10/17/2019 7:01 PM, Martin K. Petersen wrote:
> Hannes,
>
>> The BUILD_NVME define never got defined anywhere, causing NVMe
>> commands to be treated as SCSI commands when freeing the buffers.
>> This was causing a stuck discovery and a horrible crash in
>> lpfc_set_rrq_active() later on.
> Applied to 5.4/scsi-fixes, thanks!
>
The offending patches that introduced the define are:
From 12.2.0.0:
scsi: lpfc: Move SCSI and NVME Stats to hardware queue structures
commit 4c47efc140fa926f00aa59c248458d95bd7b5eab
From 12.4.0.0:
scsi: lpfc: Merge per-protocol WQ/CQ pairs into single per-cpu pair
commit c00f62e6c5468ed0673c583f1ff284274e817410
The 12.2 patch just misses some stats - no big deal.
But the 12.4 patch introduces a logic error, and is in the head of the
stable tree.
I assume that 5.4/scsi-fixes will get merged into 5.4 pre-release, and
that the stable tree will rebase to pick it up ?
-- james
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] lpfc: remove left-over BUILD_NVME defines
2019-10-18 16:36 ` [PATCH] lpfc: remove left-over BUILD_NVME defines James Smart
@ 2019-10-18 21:22 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2019-10-18 21:22 UTC (permalink / raw)
To: James Smart
Cc: Martin K. Petersen, Hannes Reinecke, Christoph Hellwig,
James Bottomley, linux-scsi, Martin George, Daniel Wagner,
Hannes Reinecke, stable
James,
> I assume that 5.4/scsi-fixes will get merged into 5.4 pre-release,
Yes.
> and that the stable tree will rebase to pick it up ?
stable/master is tracking Linus until final release.
If you want the stats issue fixed in 5.3, it's best to wait for Hannes'
commit to be merged by Linus. You can then request a stable backport.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-18 21:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20191017150019.75769-1-hare@suse.de>
[not found] ` <yq1eezake0f.fsf@oracle.com>
2019-10-18 16:36 ` [PATCH] lpfc: remove left-over BUILD_NVME defines James Smart
2019-10-18 21:22 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).