From: Andy Grover <agrover@redhat.com>
To: stgt@vger.kernel.org
Subject: [PATCH 3/3] Replace if()/goto with while()
Date: Mon, 28 Apr 2014 18:51:22 -0700 [thread overview]
Message-ID: <1398736282-1193-3-git-send-email-agrover@redhat.com> (raw)
In-Reply-To: <1398736282-1193-1-git-send-email-agrover@redhat.com>
Is equivalent and nicer-looking.
Signed-off-by: Andy Grover <agrover@redhat.com>
---
usr/bs.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/usr/bs.c b/usr/bs.c
index d6b8015..1ab86f7 100644
--- a/usr/bs.c
+++ b/usr/bs.c
@@ -122,11 +122,9 @@ retry:
}
pthread_mutex_lock(&finished_lock);
-retest:
- if (list_empty(&finished_list)) {
+
+ while (list_empty(&finished_list))
pthread_cond_wait(&finished_cond, &finished_lock);
- goto retest;
- }
while (!list_empty(&finished_list)) {
cmd = list_first_entry(&finished_list,
@@ -228,16 +226,13 @@ static void *bs_thread_worker_fn(void *arg)
sigfillset(&set);
sigprocmask(SIG_BLOCK, &set, NULL);
-
while (1) {
pthread_mutex_lock(&info->pending_lock);
pthread_cleanup_push(mutex_cleanup, &info->pending_lock);
- retest:
- if (list_empty(&info->pending_list)) {
- pthread_cond_wait(&info->pending_cond, &info->pending_lock);
- goto retest;
- }
+ while (list_empty(&info->pending_list))
+ pthread_cond_wait(&info->pending_cond,
+ &info->pending_lock);
cmd = list_first_entry(&info->pending_list,
struct scsi_cmd, bs_list);
--
1.9.0
next prev parent reply other threads:[~2014-04-29 1:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 1:51 [PATCH 1/3] Fix race on thread shutdown causing deadlock Andy Grover
2014-04-29 1:51 ` [PATCH 2/3] Remove startup_lock Andy Grover
2014-04-29 1:51 ` Andy Grover [this message]
2014-04-30 14:29 ` [PATCH 1/3] Fix race on thread shutdown causing deadlock FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398736282-1193-3-git-send-email-agrover@redhat.com \
--to=agrover@redhat.com \
--cc=stgt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox