* Memory leak of NOP-IN tasks in iscsi_tcp
@ 2016-07-11 23:23 Anton Kovalenko
2016-07-14 11:20 ` FUJITA Tomonori
0 siblings, 1 reply; 2+ messages in thread
From: Anton Kovalenko @ 2016-07-11 23:23 UTC (permalink / raw)
To: stgt@vger.kernel.org
Hi,
We've found a memory leak in tgtd recently (leaking a struct iscsi_task each nop_interval seconds).
The problem seems to have been there since the nop_interval was introduced.
My attempt at fixing it was submitted as a pull request, available at https://github.com/fujita/tgt/pull/21
The approach taken might be far from the best one possible, but the problem is severe enough to justify
doing something to solve it, even if imperfect.
Please consider accepting the pull request, or propose an alternative approach that has some chance of being accepted.
--
Best Regards, Anton Kovalenko
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Memory leak of NOP-IN tasks in iscsi_tcp
2016-07-11 23:23 Memory leak of NOP-IN tasks in iscsi_tcp Anton Kovalenko
@ 2016-07-14 11:20 ` FUJITA Tomonori
0 siblings, 0 replies; 2+ messages in thread
From: FUJITA Tomonori @ 2016-07-14 11:20 UTC (permalink / raw)
To: Anton.Kovalenko; +Cc: stgt
On Mon, 11 Jul 2016 23:23:35 +0000
Anton Kovalenko <Anton.Kovalenko@acronis.com> wrote:
> We've found a memory leak in tgtd recently (leaking a struct iscsi_task each nop_interval seconds).
> The problem seems to have been there since the nop_interval was introduced.
>
> My attempt at fixing it was submitted as a pull request, available at https://github.com/fujita/tgt/pull/21
> The approach taken might be far from the best one possible, but the problem is severe enough to justify
> doing something to solve it, even if imperfect.
Looks good. Thanks a lot!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-14 11:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-11 23:23 Memory leak of NOP-IN tasks in iscsi_tcp Anton Kovalenko
2016-07-14 11:20 ` FUJITA Tomonori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox