From: Or Gerlitz <ogerlitz@mellanox.com>
To: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>, stgt@vger.kernel.org
Cc: mitake.hitoshi@gmail.com, Roi Dayan <roid@mellanox.com>
Subject: Re: [PATCH v3] tgtd: refresh ready fds of event loop after event deletion
Date: Tue, 4 Mar 2014 17:14:41 +0200 [thread overview]
Message-ID: <5315EDE1.80103@mellanox.com> (raw)
In-Reply-To: <1393391602-6801-1-git-send-email-mitake.hitoshi@lab.ntt.co.jp>
On 26/02/2014 07:13, Hitoshi Mitake wrote:
> For example, we can produce segfault of tgtd under heavy load. Below
> is a backtrace obtained from the core file:
> (gdb) bt
> #0 0x0000000000000000 in ?? ()
> #1 0x0000000000411419 in event_loop () at tgtd.c:414
> #2 0x0000000000411b65 in main (argc=<value optimized out>, argv=<value optimized out>) at tgtd.c:591
>
> To be honest, I still don't find an event handler which calls
> tgt_event_del() for other fds. But with this modification, the above
> segfault is avoided. The change seems to be effective.
Just want to make sure I follow --- you do have a way to reproduce the
bug, but from code inspection you didn't find an event handler in tgt
which calls tgt_event_del() for "other" fds which is the trigger for
the bug, right?
Can you please provide the steps to reproduce the bug?
Or.
next prev parent reply other threads:[~2014-03-04 15:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 5:13 [PATCH v3] tgtd: refresh ready fds of event loop after event deletion Hitoshi Mitake
2014-02-26 5:22 ` FUJITA Tomonori
2014-02-26 5:33 ` Hitoshi Mitake
2014-03-04 15:14 ` Or Gerlitz [this message]
2014-03-06 6:54 ` Hitoshi Mitake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5315EDE1.80103@mellanox.com \
--to=ogerlitz@mellanox.com \
--cc=mitake.hitoshi@gmail.com \
--cc=mitake.hitoshi@lab.ntt.co.jp \
--cc=roid@mellanox.com \
--cc=stgt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox