public inbox for stgt@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Duncan <lduncan@suse.com>
To: stgt@vger.kernel.org
Subject: tgtadm delete without lld specified?
Date: Wed, 16 Apr 2014 16:40:09 -0700	[thread overview]
Message-ID: <534F14D9.8090507@suse.com> (raw)

I am debugging a problem on SUSE 11 SP3, with tgt 0.9.10.

I am creating two iSCSI targets using targets.conf. Neither target
specifies a low-level driver, and there is no default-driver specified
either.

The targets looks something like this:

<target iqn....t1>
    backing-store /dev/some-device
    vendor_id someid
    product_id volume-num1
</target>

I create two of these targets, t1, and t2, then I using open-iscsi to
login to the first target, t1, then logout.

Then I run "tgt-admin --delete "iqn...t1". As you know, this just runs
"tgtadm --op delete --mode target --tid=<tid-of-t1>". No low-level
driver is specified.

Then I try to login to the second target, t2, using open-iscsi, and
the login hangs. This is because tgtd has died.

Further analysis shows that tgtd dies because when it tries to look up
the iscsi target structure for t2, the t1 entry is still around. And
when the code tries to get the name of this no-longer-existing target,
it gets NULL and tries to compare that with the iqn name being
added. This makes strcmp() very unhappy.

I find that if I manually specify the lld either on the command line
of "tgtadm", or in one of the config files, then this problem goes
away.

It looks like when I don't specify any LLD the upper-level code
defaults to low-lever-driver zero! This seems like a bug to me.

Shouldn't the "tgtadm" command enforce specifying the low-level
driver?
-- 
Lee Duncan
SUSE Labs

             reply	other threads:[~2014-04-16 23:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-16 23:40 Lee Duncan [this message]
2014-04-20 12:20 ` tgtadm delete without lld specified? FUJITA Tomonori
2014-04-21 16:44   ` Lee Duncan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=534F14D9.8090507@suse.com \
    --to=lduncan@suse.com \
    --cc=stgt@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox