From: Allen Pais <allen.lkml@gmail.com>
To: linux-scsi@vger.kernel.org
Cc: nab@linux-iscsi.org, target-devel@vger.kernel.org,
Allen Pais <allen.lkml@gmail.com>
Subject: [PATCH 1/5] iscsi-target: use setup_timer() helper.
Date: Fri, 22 Sep 2017 10:20:50 +0000 [thread overview]
Message-ID: <1506074934-15062-2-git-send-email-allen.lkml@gmail.com> (raw)
In-Reply-To: <1506074934-15062-1-git-send-email-allen.lkml@gmail.com>
Use setup_timer function instead of initializing timer with the
function and data fields.
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
drivers/target/iscsi/iscsi_target_nego.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c
index 7a6751f..5b22f01 100644
--- a/drivers/target/iscsi/iscsi_target_nego.c
+++ b/drivers/target/iscsi/iscsi_target_nego.c
@@ -618,10 +618,9 @@ static void iscsi_target_do_login_rx(struct work_struct *work)
conn->login_kworker = current;
allow_signal(SIGINT);
- init_timer(&login_timer);
+ setup_timer(&login_timer, iscsi_target_login_timeout,
+ (unsigned long)conn);
login_timer.expires = (get_jiffies_64() + TA_LOGIN_TIMEOUT * HZ);
- login_timer.data = (unsigned long)conn;
- login_timer.function = iscsi_target_login_timeout;
add_timer(&login_timer);
pr_debug("Starting login_timer for %s/%d\n", current->comm, current->pid);
--
2.7.4
next prev parent reply other threads:[~2017-09-22 10:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 10:20 [PATCH 0/5] use setup_timer() helper function Allen Pais
2017-09-22 10:20 ` Allen Pais [this message]
2017-09-22 10:20 ` [PATCH 2/5] iscsi-target: use setup_timer() helper Allen Pais
2017-09-22 10:20 ` [PATCH 3/5] " Allen Pais
2017-09-22 10:20 ` [PATCH 4/5] " Allen Pais
2017-09-22 10:20 ` [PATCH 5/5] " Allen Pais
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506074934-15062-2-git-send-email-allen.lkml@gmail.com \
--to=allen.lkml@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).