From mboxrd@z Thu Jan 1 00:00:00 1970 From: Allen Pais Date: Fri, 22 Sep 2017 10:20:50 +0000 Subject: [PATCH 1/5] iscsi-target: use setup_timer() helper. Message-Id: <1506074934-15062-2-git-send-email-allen.lkml@gmail.com> List-Id: References: <1506074934-15062-1-git-send-email-allen.lkml@gmail.com> In-Reply-To: <1506074934-15062-1-git-send-email-allen.lkml@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-scsi@vger.kernel.org Cc: nab@linux-iscsi.org, target-devel@vger.kernel.org, Allen Pais Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Allen Pais --- drivers/target/iscsi/iscsi_target_nego.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c index 7a6751f..5b22f01 100644 --- a/drivers/target/iscsi/iscsi_target_nego.c +++ b/drivers/target/iscsi/iscsi_target_nego.c @@ -618,10 +618,9 @@ static void iscsi_target_do_login_rx(struct work_struct *work) conn->login_kworker = current; allow_signal(SIGINT); - init_timer(&login_timer); + setup_timer(&login_timer, iscsi_target_login_timeout, + (unsigned long)conn); login_timer.expires = (get_jiffies_64() + TA_LOGIN_TIMEOUT * HZ); - login_timer.data = (unsigned long)conn; - login_timer.function = iscsi_target_login_timeout; add_timer(&login_timer); pr_debug("Starting login_timer for %s/%d\n", current->comm, current->pid); -- 2.7.4