[PATCH 00/20] tcmu update

[PATCH 00/20] tcmu update

[Mike Christie]

Hey Nick,

The following patches were made over your for-next branch on target-pending.

Patches 1 -3 are ok for the next merge window:

- Patches 1 - 2 are misc fixes/changes.
- Patch 3 is just a cleanup to use the proper macro.

Patches 4 - 20 were posted later and have not been on the list
for as long and so maybe are better for the next-next merge
window.

- Patch 4 fixes the SCSI value that TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE
is converted to. It is needed by patches 5 - 20.
- Patch 5 - 18 fix bugs in tcmu's ring buffer code.
- Patch 18 - 20 allow you to configure the size of the ring buffer
and how long we wait for ring memory.

Re: [PATCH 00/20] tcmu update

[Mike Christie]

On 10/25/2017 11:47 AM, Mike Christie wrote:
> - Patch 5 - 18 fix bugs in tcmu's ring buffer code.
> - Patch 18 - 20 allow you to configure the size of the ring buffer

Hey Nick,

If you are out there, do not merge patches 5 - 20. I have a patchset
that will simplify things.

You should also drop

commit b8501553476c2eabbd15da79e152a84a9a67dc5a
Author: Xiubo Li <lixiubo@cmss.chinamobile.com>
Date:   Wed Jul 12 15:16:07 2017 +0800

    tcmu: Add fifo type waiter list support to avoid starvation

https://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git/commit/?h=for-next&idị501553476c2eabbd15da79e152a84a9a67dc5a

and

commit 04229774f69250e0f7e63b4d1b50ba8371c9d165
Author: Dan Carpenter <dan.carpenter@oracle.com>
Date:   Tue Aug 1 23:09:17 2017 +0300

    tcmu: Oops in unmap_thread_fn()

    Calling list_del() on the iterator pointer in list_for_each_entry() will
    cause an oops.  We need to user the _safe() version for that.

https://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git/commit/?h=for-next&id\x04229774f69250e0f7e63b4d1b50ba8371c9d165

from your for-next branch. That first patch added several regressions
and the second patch is then not needed. My new patchset will fix the
starvation issue.