From: Chengguang Xu <cgxu519@gmx.com>
To: nab@linux-iscsi.org
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-kernel@vger.kernel.org, Chengguang Xu <cgxu519@gmx.com>
Subject: [RESEND PATCH] target: fix potential memory leak in option parsing
Date: Wed, 13 Jun 2018 05:27:26 +0000 [thread overview]
Message-ID: <1528867646-138322-1-git-send-email-cgxu519@gmx.com> (raw)
When specifying same string type option several times,
current option parsing will cause memory leak. Hence,
call kfree for previous one in this case.
Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
---
drivers/target/target_core_configfs.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
index 5ccef7d..5512432 100644
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -1661,6 +1661,7 @@ static ssize_t target_pr_res_aptpl_metadata_store(struct config_item *item,
token = match_token(ptr, tokens, args);
switch (token) {
case Opt_initiator_fabric:
+ kfree(i_fabric);
i_fabric = match_strdup(args);
if (!i_fabric) {
ret = -ENOMEM;
@@ -1668,6 +1669,7 @@ static ssize_t target_pr_res_aptpl_metadata_store(struct config_item *item,
}
break;
case Opt_initiator_node:
+ kfree(i_port);
i_port = match_strdup(args);
if (!i_port) {
ret = -ENOMEM;
@@ -1682,6 +1684,7 @@ static ssize_t target_pr_res_aptpl_metadata_store(struct config_item *item,
}
break;
case Opt_initiator_sid:
+ kfree(isid);
isid = match_strdup(args);
if (!isid) {
ret = -ENOMEM;
@@ -1739,6 +1742,7 @@ static ssize_t target_pr_res_aptpl_metadata_store(struct config_item *item,
* PR APTPL Metadata for Target Port
*/
case Opt_target_fabric:
+ kfree(t_fabric);
t_fabric = match_strdup(args);
if (!t_fabric) {
ret = -ENOMEM;
@@ -1746,6 +1750,7 @@ static ssize_t target_pr_res_aptpl_metadata_store(struct config_item *item,
}
break;
case Opt_target_node:
+ kfree(t_port);
t_port = match_strdup(args);
if (!t_port) {
ret = -ENOMEM;
--
1.8.3.1
next reply other threads:[~2018-06-13 5:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 5:27 Chengguang Xu [this message]
2018-06-13 16:10 ` [RESEND PATCH] target: fix potential memory leak in option parsing Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528867646-138322-1-git-send-email-cgxu519@gmx.com \
--to=cgxu519@gmx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).