From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Christie Date: Sat, 02 Feb 2019 03:01:21 +0000 Subject: [PATCH] tcmu: wait for nl reply only if there are listeners Message-Id: <1549076481-15420-1-git-send-email-mchristi@redhat.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: target-devel@vger.kernel.org genlmsg_multicast_allns used to return -ESRCH even if the message was successfully sent to a listener. With commit: commit cb9f7a9a5c96a773bbc9c70660dc600cfff82f82 Author: Nicolas Dichtel Date: Tue Feb 6 14:48:32 2018 +0100 netlink: ensure to loop over all netns in genlmsg_multicast_allns() it now will return success if the message was sent to a listener. With that patch, tcmu can now immediately fail if -ESRCH is returned because we know there will be no reply. Signed-off-by: Mike Christie --- drivers/target/target_core_user.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c index 5831e0e..dccc13c 100644 --- a/drivers/target/target_core_user.c +++ b/drivers/target/target_core_user.c @@ -1794,9 +1794,6 @@ static int tcmu_netlink_event_send(struct tcmu_dev *udev, ret = genlmsg_multicast_allns(&tcmu_genl_family, skb, 0, TCMU_MCGRP_CONFIG, GFP_KERNEL); - /* We don't care if no one is listening */ - if (ret = -ESRCH) - ret = 0; if (!ret) ret = tcmu_wait_genl_cmd_reply(udev); return ret; -- 1.8.3.1