From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DA10C433FE for ; Thu, 31 Mar 2022 21:22:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233183AbiCaVYI (ORCPT ); Thu, 31 Mar 2022 17:24:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241800AbiCaVYH (ORCPT ); Thu, 31 Mar 2022 17:24:07 -0400 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E37823D470 for ; Thu, 31 Mar 2022 14:22:18 -0700 (PDT) Received: by mail-pg1-x52b.google.com with SMTP id w21so772153pgm.7 for ; Thu, 31 Mar 2022 14:22:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=x3SePf6cYyzJ/sV6xHzMCnP/4ErKQDoUNlfoUc3FU/o=; b=pbUrFWcZ2skLn6FAZKUppr3B/0KcKYvs7TVqCpR/V/wpljp0wGqVFJrj7vRAyJlZaG N0rqPpfA6Eyg0swWL6TZQ2Ao2/Gs7zjCBpYKtGgeftbX9wZo5RutaAIdeBlBMTpypBzx TGel8IyxgFZbX40O+FfItMq6FYmWpwXK95ZvQAB+ZeW7GfasepxJTsDFJwiOIPDzRraq 2L0hLd+MVFTJd98uB0m2smroBZU8rq8LJ+t/lj+n8QZvP6ZooUOk2UUyhrV3IJrm+6tP Zl+ZU+WwG6a53qFjsvhKcgbDV5Sb6n1XbUYHqQhzrdurBPG4yfswzxy4qsxPu50Vppzu xLQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=x3SePf6cYyzJ/sV6xHzMCnP/4ErKQDoUNlfoUc3FU/o=; b=Uy2GB5XwYHKCGTidp160rzRBM0mBQpSPsl7RftMDHUOguSnvoBFoI9p2kA85Lnl8z2 7WfToSQNjn87zNv/HSwNxfGzL+tFoyjUrAJ40xFZYpKVu5w1NRwV6sNtaVLcWFdyOtib aJfmb3RRKImKqwY38Yhqm60pusCtjsfaF/9nxCsELMJ0fZb/ubGUHtPtt9G0Ykb6cV5t DOvnMgik/PSyvWUuif1VeNvCCjIpJ6GYGcxQ+Xrrjsjd7wHp8UwLYjAwLQdi/Z2cmwtg aR+w170IVQ7wPnqZ5Cg1bmCBwulpn/UWqeHDQpLdcQNLni/snBwDV46mDs74oup0g7d7 zNFQ== X-Gm-Message-State: AOAM530F4IPKZxmgGq0Jn/5a0DxICNIoSjpWvAjXhMcXpkTv0rTeKGhO rNzRq3gavfjqnfQNeYhBjxRS1Q== X-Google-Smtp-Source: ABdhPJwYnU9r41ORdf19G02EFb5yhsyLJV8xzLTtxC7Sx8NiXMpF/1DkwJ2vuON7bztWgA+FZZylpQ== X-Received: by 2002:a05:6a00:328f:b0:4fa:95b5:e1ff with SMTP id ck15-20020a056a00328f00b004fa95b5e1ffmr7412958pfb.60.1648761737704; Thu, 31 Mar 2022 14:22:17 -0700 (PDT) Received: from ?IPV6:2600:380:772e:9a93:98d9:fd90:ab06:5943? ([2600:380:772e:9a93:98d9:fd90:ab06:5943]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm410220pfu.56.2022.03.31.14.22.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Mar 2022 14:22:17 -0700 (PDT) Message-ID: <1eb268c5-3420-0263-3f0c-7d3982f8f512@kernel.dk> Date: Thu, 31 Mar 2022 15:22:14 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 4/5] block: turn bio_kmalloc into a simple kmalloc wrapper Content-Language: en-US To: Marek Szyprowski , Christoph Hellwig Cc: Coly Li , Mike Snitzer , Song Liu , "Martin K. Petersen" , Josef Bacik , David Sterba , Phillip Lougher , linux-block@vger.kernel.org, dm-devel@redhat.com, linux-kernel@vger.kernel.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20220308061551.737853-1-hch@lst.de> <20220308061551.737853-5-hch@lst.de> <6696cc6a-3e3f-035e-5b8c-05ea361383f3@samsung.com> From: Jens Axboe In-Reply-To: <6696cc6a-3e3f-035e-5b8c-05ea361383f3@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org On 3/31/22 3:18 PM, Marek Szyprowski wrote: > Hi Christoph, > > On 08.03.2022 07:15, Christoph Hellwig wrote: >> Remove the magic autofree semantics and require the callers to explicitly >> call bio_init to initialize the bio. >> >> This allows bio_free to catch accidental bio_put calls on bio_init()ed >> bios as well. >> >> Signed-off-by: Christoph Hellwig > > This patch, which landed in today's next-20220331 as commit 57c47b42f454 > ("block: turn bio_kmalloc into a simple kmalloc wrapper"), breaks badly > all my test systems, which use squashfs initrd: The series has been reverted on the block side, so next linux-next should be fine again. We'll try again for 5.19. -- Jens Axboe