From: Matthew Wilcox <willy@infradead.org>
To: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org,
linux1394-devel@lists.sourceforge.net, linux-usb@vger.kernel.org,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, Juergen Gross <jgross@suse.com>,
qla2xxx-upstream@qlogic.com,
Kent Overstreet <kent.overstreet@gmail.com>,
Jens Axboe <axboe@kernel.dk>
Cc: Matthew Wilcox <mawilcox@microsoft.com>
Subject: [PATCH 0/2] Use sbitmap instead of percpu_ida
Date: Tue, 15 May 2018 16:00:41 +0000 [thread overview]
Message-ID: <20180515160043.27044-1-willy@infradead.org> (raw)
From: Matthew Wilcox <mawilcox@microsoft.com>
This is a pretty rough-and-ready conversion of the target drivers
from using percpu_ida to sbitmap. It compiles; I don't have a target
setup, so it's completely untested. I haven't tried to do anything
particularly clever here, so it's possible that, for example, the wait
queue in iscsi_target_util could be more clever, like the block layer
uses multiple wait queues to avoid pingpongs. Or maybe we could figure
out a way to not store the CPU that the ID was allocated on, or perhaps
the options I specified to sbitmap_queue_init() are suboptimal.
Patch 2 isn't interesting; it just deletes the implementation. Patch 1
will be where all the action is.
Matthew Wilcox (2):
Convert target drivers to use sbitmap
Remove percpu_ida
drivers/scsi/qla2xxx/qla_target.c | 16 +-
drivers/target/iscsi/iscsi_target_util.c | 34 +-
drivers/target/sbp/sbp_target.c | 8 +-
drivers/target/target_core_transport.c | 5 +-
drivers/target/tcm_fc/tfc_cmd.c | 11 +-
drivers/usb/gadget/function/f_tcm.c | 8 +-
drivers/vhost/scsi.c | 9 +-
drivers/xen/xen-scsiback.c | 8 +-
include/linux/percpu_ida.h | 83 -----
include/target/iscsi/iscsi_target_core.h | 1 +
include/target/target_core_base.h | 5 +-
lib/Makefile | 2 +-
lib/percpu_ida.c | 391 -----------------------
13 files changed, 74 insertions(+), 507 deletions(-)
delete mode 100644 include/linux/percpu_ida.h
delete mode 100644 lib/percpu_ida.c
--
2.17.0
next reply other threads:[~2018-05-15 16:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 16:00 Matthew Wilcox [this message]
2018-05-15 16:00 ` [PATCH 1/2] Convert target drivers to use sbitmap Matthew Wilcox
2018-05-15 16:11 ` Jens Axboe
2018-05-15 16:20 ` Jens Axboe
2018-06-12 1:18 ` Jens Axboe
2018-06-12 3:06 ` Matthew Wilcox
2018-05-16 5:54 ` Felipe Balbi
2018-05-16 12:47 ` kbuild test robot
2018-05-16 12:47 ` [RFC PATCH] iscsit_wait_for_tag() can be static kbuild test robot
2018-06-12 15:22 ` [PATCH 1/2] Convert target drivers to use sbitmap Bart Van Assche
2018-06-12 16:15 ` Matthew Wilcox
2018-06-12 16:32 ` Bart Van Assche
2018-06-12 18:08 ` Matthew Wilcox
2018-05-15 16:00 ` [PATCH 2/2] Remove percpu_ida Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180515160043.27044-1-willy@infradead.org \
--to=willy@infradead.org \
--cc=axboe@kernel.dk \
--cc=jgross@suse.com \
--cc=kent.overstreet@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=mawilcox@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=qla2xxx-upstream@qlogic.com \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).