From: Christoph Hellwig <hch@infradead.org>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH 03/15] target: fix __transport_register_session locking
Date: Thu, 19 Jul 2018 20:38:21 +0000 [thread overview]
Message-ID: <20180719203821.GA14654@infradead.org> (raw)
In-Reply-To: <1531696591-8558-4-git-send-email-mchristi@redhat.com>
On Sun, Jul 15, 2018 at 06:16:19PM -0500, Mike Christie wrote:
> When __transport_register_session is called from
> transport_register_session irqs will already have been disabled,
> so we do not want the unlock irq call to enable them until
> the higher level has done the final
> spin_unlock_irqrestore/spin_unlock_irq.
if you use up your line length this could be:
so we do not want the unlock irq call to enable them until the higher
level has done the final spin_unlock_irqrestore/spin_unlock_irq.
>
> This has __transport_register_session use the save/restore
> call.
Can be condensed as well.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2018-07-19 20:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-15 23:16 [PATCH 03/15] target: fix __transport_register_session locking Mike Christie
2018-07-18 22:11 ` Bart Van Assche
2018-07-19 20:38 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719203821.GA14654@infradead.org \
--to=hch@infradead.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).