From: Christoph Hellwig <hch@infradead.org>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH 07/15] target: rename target_alloc_session
Date: Thu, 19 Jul 2018 20:42:16 +0000 [thread overview]
Message-ID: <20180719204216.GD14654@infradead.org> (raw)
In-Reply-To: <1531696591-8558-8-git-send-email-mchristi@redhat.com>
On Sun, Jul 15, 2018 at 06:16:23PM -0500, Mike Christie wrote:
> Rename target_alloc_session to target_setup_session to avoid
> confusion with the other transport session allocation
> function that only allocates the session and because
> the target_alloc_session does so more. It allocates the
> session, sets up the nacl and egisters the session.
>
> The next patch will then add a remove function to match the
> setup in this one, so it should make sense for all drivers,
> except iscsi, to just call those 2 functions to setup and remove
> a session.
Ok.
> iscsi will continue to be the odd driver.
Wish we could sort that out eventually..
Otherwise looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2018-07-19 20:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-15 23:16 [PATCH 07/15] target: rename target_alloc_session Mike Christie
2018-07-18 22:23 ` Bart Van Assche
2018-07-19 20:42 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719204216.GD14654@infradead.org \
--to=hch@infradead.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).