From: David Disseldorp <ddiss@suse.de>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH v3] target: add emulate_pr backstore attr to toggle PR support
Date: Tue, 30 Oct 2018 14:07:12 +0000 [thread overview]
Message-ID: <20181030150712.5779ad83@suse.de> (raw)
In-Reply-To: <20180625185658.31141-1-ddiss@suse.de>
Hi Mike,
On Thu, 28 Jun 2018 14:34:38 -0500, Mike Christie wrote:
> On 06/28/2018 09:48 AM, David Disseldorp wrote:
...
> > So how should we proceed here? Separate emulate_pr and pgr_support
> > interfaces would imply that this change could go in as-is, while a
> > multi-state interface would probably require more thought.
> >
>
> I think separate is going to be easier.
...
> If we do multiple files then emulate_pr is very clear what is meant
> across all backends and works like other device attributes.
I think we reached consensus here, but I don't have any acks for this
patch so will rebase against current mainline and resend.
Cheers, David
prev parent reply other threads:[~2018-10-30 14:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 18:56 [PATCH v3] target: add emulate_pr backstore attr to toggle PR support David Disseldorp
2018-06-26 12:35 ` Bodo Stroesser
2018-06-27 18:22 ` Mike Christie
2018-06-27 22:05 ` David Disseldorp
2018-06-28 14:48 ` David Disseldorp
2018-06-28 19:34 ` Mike Christie
2018-10-30 14:07 ` David Disseldorp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181030150712.5779ad83@suse.de \
--to=ddiss@suse.de \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).