From: David Disseldorp <ddiss@suse.de>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH v7 3/5] target: add device vendor_id configfs attribute
Date: Thu, 06 Dec 2018 13:01:44 +0000 [thread overview]
Message-ID: <20181206140144.0afe056a@suse.de> (raw)
In-Reply-To: <20181205121838.23982-4-ddiss@suse.de>
On Thu, 6 Dec 2018 15:25:42 +0300, Roman Bolshakov wrote:
> > /*
> > + * STANDARD and VPD page 0x80 T10 Vendor Identification
>
> Perhaps you meant 0x83 (Device Identification VPD page, T10 vendor ID
> based designator). INQUIRY page 0x80 is Unit Serial Number.
Indeed, the comment should refer to page 0x83.
@Martin: all patches in this series have now been reviewed+acked. Can
you fix the above comment (s/0x80/0x83) if/when you merge, or
should I resend the series with this fixed?
Cheers, David
next prev parent reply other threads:[~2018-12-06 13:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 12:18 [PATCH v7 3/5] target: add device vendor_id configfs attribute David Disseldorp
2018-12-06 12:25 ` Roman Bolshakov
2018-12-06 13:01 ` David Disseldorp [this message]
2018-12-06 13:22 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206140144.0afe056a@suse.de \
--to=ddiss@suse.de \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox