From: David Disseldorp <ddiss@suse.de>
To: target-devel@vger.kernel.org
Cc: martin.petersen@oracle.com, michael.christie@oracle.com,
David Disseldorp <ddiss@suse.de>, Chris Boot <bootc@bootc.net>
Subject: [PATCH 2/3] scsi: target: sbp: drop incorrect asc/ascq usage
Date: Wed, 28 Jul 2021 13:53:53 +0200 [thread overview]
Message-ID: <20210728115353.2396-3-ddiss@suse.de> (raw)
In-Reply-To: <20210728115353.2396-1-ddiss@suse.de>
The se_cmd scsi_asc and scsi_ascq members are only used for tracking
ALUA SCSI sense detail between target_core_alua and
translate_sense_reason(), so they're effectively always zero here.
Signed-off-by: David Disseldorp <ddiss@suse.de>
Cc: Chris Boot <bootc@bootc.net>
---
drivers/target/sbp/sbp_target.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/target/sbp/sbp_target.c b/drivers/target/sbp/sbp_target.c
index 4d3ceee23622..b9f9fb5d7e63 100644
--- a/drivers/target/sbp/sbp_target.c
+++ b/drivers/target/sbp/sbp_target.c
@@ -1389,8 +1389,8 @@ static void sbp_sense_mangle(struct sbp_target_request *req)
(sense[0] & 0x80) | /* valid */
((sense[2] & 0xe0) >> 1) | /* mark, eom, ili */
(sense[2] & 0x0f); /* sense_key */
- status[2] = se_cmd->scsi_asc; /* sense_code */
- status[3] = se_cmd->scsi_ascq; /* sense_qualifier */
+ status[2] = 0; /* XXX sense_code */
+ status[3] = 0; /* XXX sense_qualifier */
/* information */
status[4] = sense[3];
--
2.26.2
next prev parent reply other threads:[~2021-07-28 11:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 11:53 [PATCH 0/3] scsi: target: se_cmd cleanups and race fix David Disseldorp
2021-07-28 11:53 ` [PATCH 1/3] scsi: target: avoid using lun_tg_pt_gp after unlock David Disseldorp
2021-07-28 11:53 ` David Disseldorp [this message]
2021-07-28 11:53 ` [PATCH 3/3] scsi: target: drop unnecessary se_cmd asc/ascq members David Disseldorp
2021-08-01 18:55 ` [PATCH 0/3] scsi: target: se_cmd cleanups and race fix Mike Christie
2021-08-03 2:57 ` Martin K. Petersen
2021-08-10 5:20 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210728115353.2396-3-ddiss@suse.de \
--to=ddiss@suse.de \
--cc=bootc@bootc.net \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox