From: David Jeffery <djeffery@redhat.com>
To: linux-rdma@vger.kernel.org
Cc: target-devel@vger.kernel.org, Sagi Grimberg <sagi@grimberg.me>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
Laurence Oberman <loberman@redhat.com>,
David Jeffery <djeffery@redhat.com>
Subject: [PATCH 1/2] isert: support for unsolicited NOPIN with no response.
Date: Fri, 11 Mar 2022 12:57:12 -0500 [thread overview]
Message-ID: <20220311175713.2344960-2-djeffery@redhat.com> (raw)
In-Reply-To: <20220311175713.2344960-1-djeffery@redhat.com>
The isert module has only supported sending a NOPIN as a response to a
NOPOUT. In order to be able to use an unsolicited NOPIN to inform the
initiator of max_cmd_sn changes, isert needs to be able to send a NOPIN
as needed.
Signed-off-by: David Jeffery <djeffery@redhat.com>
Tested-by: Laurence Oberman <loberman@redhat.com>
---
drivers/infiniband/ulp/isert/ib_isert.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
index 636d590765f9..b8390ad762eb 100644
--- a/drivers/infiniband/ulp/isert/ib_isert.c
+++ b/drivers/infiniband/ulp/isert/ib_isert.c
@@ -1469,6 +1469,7 @@ isert_put_cmd(struct isert_cmd *isert_cmd, bool comp_err)
break;
case ISCSI_OP_REJECT:
case ISCSI_OP_NOOP_OUT:
+ case ISCSI_OP_NOOP_IN:
case ISCSI_OP_TEXT:
hdr = (struct iscsi_text_rsp *)&isert_cmd->tx_desc.iscsi_header;
/* If the continue bit is on, keep the command alive */
@@ -1858,7 +1859,14 @@ isert_put_nopin(struct iscsi_cmd *cmd, struct iscsi_conn *conn,
isert_dbg("conn %p Posting NOPIN Response\n", isert_conn);
- return isert_post_response(isert_conn, isert_cmd);
+ if (nopout_response)
+ return isert_post_response(isert_conn, isert_cmd);
+
+ /* pointer init since didn't go through isert_allocate_cmd */
+ isert_cmd->conn = isert_conn;
+ isert_cmd->iscsi_cmd = cmd;
+
+ return ib_post_send(isert_conn->qp, send_wr, NULL);
}
static int
@@ -2159,6 +2167,7 @@ isert_immediate_queue(struct iscsi_conn *conn, struct iscsi_cmd *cmd, int state)
spin_unlock_bh(&conn->cmd_lock);
isert_put_cmd(isert_cmd, true);
break;
+ case ISTATE_SEND_NOPIN_NO_RESPONSE:
case ISTATE_SEND_NOPIN_WANT_RESPONSE:
ret = isert_put_nopin(cmd, conn, false);
break;
--
2.31.1
next prev parent reply other threads:[~2022-03-11 17:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 17:57 [Patch 0/2] iscsit/isert deadlock prevention under heavy I/O David Jeffery
2022-03-11 17:57 ` David Jeffery [this message]
2022-03-11 17:57 ` [PATCH 2/2] iscsit: increment max_cmd_sn for isert on command release David Jeffery
2022-03-11 19:08 ` [Patch 0/2] iscsit/isert deadlock prevention under heavy I/O Laurence Oberman
2022-03-13 9:59 ` Max Gurtovoy
2022-03-14 13:57 ` David Jeffery
2022-03-14 14:52 ` Max Gurtovoy
2022-03-14 15:55 ` David Jeffery
2022-03-14 17:40 ` Laurence Oberman
2022-03-16 10:38 ` Max Gurtovoy
2022-03-16 13:07 ` Laurence Oberman
2022-03-16 14:39 ` Sagi Grimberg
2022-03-16 15:26 ` Laurence Oberman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220311175713.2344960-2-djeffery@redhat.com \
--to=djeffery@redhat.com \
--cc=linux-rdma@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=mgurtovoy@nvidia.com \
--cc=sagi@grimberg.me \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).