From: Leon Romanovsky <leon@kernel.org>
To: Mike Christie <michael.christie@oracle.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
linux-rdma@vger.kernel.org, Sagi Grimberg <sagi@grimberg.me>,
Saravanan Vajravel <saravanan.vajravel@broadcom.com>,
Selvin Xavier <selvin.xavier@broadcom.com>,
target-devel@vger.kernel.org
Subject: Re: [PATCH rdma-next] Revert "IB/isert: Fix incorrect release of isert connection"
Date: Tue, 22 Aug 2023 16:58:14 +0300 [thread overview]
Message-ID: <20230822135814.GD6029@unreal> (raw)
In-Reply-To: <38350699-ce4c-4298-8ebf-c9c6b5a72c2e@oracle.com>
On Mon, Aug 21, 2023 at 11:25:35AM -0500, Mike Christie wrote:
> On 8/21/23 2:57 AM, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@nvidia.com> Commit: 699826f4e30a ("IB/isert: Fix incorrect release of isert connection") is
>
> Was the issue described in that commit just not correct? Or was it
> supposed to be for some sort of race'y error path?
>
> It looks like that analysis was wrong for the normal login/logout path where
> we call:
I came to same conclusion when analyzed Dennis's report.
Thanks
>
> 1. isert_init_conn sets kref to 1.
> 2. If we are connected we set kref to 2 via isert_connected_handler -> kref_get
> 3. When we logout from there then isert_wait_conn -> queue_work release_work
> and release_work does isert_put_conn so kref = 1.
> 4. Then we do isert_free_conn which does isert_put_conn to set the kref to 0
> and then free the conn.
>
> So the patch in this mail looks ok.
>
> I checked most of the error paths, but I might have missed some. It looks ok
> for them as well.
next prev parent reply other threads:[~2023-08-22 13:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 7:57 [PATCH rdma-next] Revert "IB/isert: Fix incorrect release of isert connection" Leon Romanovsky
2023-08-21 16:25 ` Mike Christie
2023-08-22 13:58 ` Leon Romanovsky [this message]
2023-08-23 4:23 ` Saravanan Vajravel
2023-08-22 13:49 ` Dennis Dalessandro
2023-08-22 14:01 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230822135814.GD6029@unreal \
--to=leon@kernel.org \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=sagi@grimberg.me \
--cc=saravanan.vajravel@broadcom.com \
--cc=selvin.xavier@broadcom.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).