From: Mike Christie <michael.christie@oracle.com>
To: Dmitry Bogdanov <d.bogdanov@yadro.com>
Cc: Martin Petersen <martin.petersen@oracle.com>,
target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux@yadro.com, Roman Bolshakov <r.bolshakov@yadro.com>
Subject: Re: [PATCH 4/6] scsi: target: core: add emulate_rsoc attribute
Date: Mon, 29 Aug 2022 13:13:36 -0500 [thread overview]
Message-ID: <26c77569-9014-6baf-55d6-0dc1e470ed8f@oracle.com> (raw)
In-Reply-To: <20220815063504.GA17595@yadro.com>
On 8/15/22 1:35 AM, Dmitry Bogdanov wrote:
> On Fri, Aug 12, 2022 at 01:12:12PM -0500, michael.christie@oracle.com wrote:
>>
>> On 8/12/22 6:34 AM, Dmitry Bogdanov wrote:
>>> On Thu, Aug 11, 2022 at 10:43:24PM -0500, Mike Christie wrote:
>>>>
>>>> On 7/18/22 7:01 AM, Dmitry Bogdanov wrote:
>>>>> Make support of RSOC turned off by emulate_rsoc attibute.
>>>>>
>>>>
>>>> What was the reason for this?
>>> Looks like, it was by analogue to other emulate_* attibutes. But
>>> actually RSOC itself is independent to a backstore device, so better to
>>> drop this patch :)
>>
>> I was actually ok with it in general. It seemed nice for testing.
>>
>> I was asking because I thought you hit some regressions when it was
>> on and just wanted you add that info to the git commit.
> No, there was no regression.
> So, better to keep this patch but to add to a commit message, that it
> is just for testing purposes?
Sorry for the late reply. I was on vacation.
Yeah, that seems fine. scsi-ml will take different code paths if
RSOC is supported. Other OSs might do the same so it might be useful.
next prev parent reply other threads:[~2022-08-29 18:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 12:01 [PATCH 0/6] add support of RSOC command Dmitry Bogdanov
2022-07-18 12:01 ` [PATCH 1/6] scsi: target: core: " Dmitry Bogdanov
2022-07-19 10:08 ` kernel test robot
2022-07-18 12:01 ` [PATCH 2/6] scsi: target: core: add list of opcodes for RSOC Dmitry Bogdanov
2022-08-12 3:38 ` Mike Christie
2022-08-12 8:03 ` Dmitry Bogdanov
2022-08-13 7:49 ` Christoph Hellwig
2022-08-15 10:59 ` Dmitry Bogdanov
2022-07-18 12:01 ` [PATCH 3/6] scsi: target: core: dynamic opcode support in RSOC Dmitry Bogdanov
2022-07-19 12:40 ` kernel test robot
2022-08-12 3:43 ` Mike Christie
2022-08-12 11:30 ` Dmitry Bogdanov
2022-07-18 12:01 ` [PATCH 4/6] scsi: target: core: add emulate_rsoc attribute Dmitry Bogdanov
2022-08-12 3:43 ` Mike Christie
2022-08-12 11:34 ` Dmitry Bogdanov
2022-08-12 18:12 ` michael.christie
2022-08-15 6:35 ` Dmitry Bogdanov
2022-08-29 18:13 ` Mike Christie [this message]
2022-07-18 12:01 ` [PATCH 5/6] scsi: target: core: dynamicaly set dpofua in usage_bits Dmitry Bogdanov
2022-07-18 12:01 ` [PATCH 6/6] scsi: target: check emulate_3pc for RECEIVE COPY Dmitry Bogdanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26c77569-9014-6baf-55d6-0dc1e470ed8f@oracle.com \
--to=michael.christie@oracle.com \
--cc=d.bogdanov@yadro.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@yadro.com \
--cc=martin.petersen@oracle.com \
--cc=r.bolshakov@yadro.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).