From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH 13/20] target/iscsi: Reduce number of __iscsit_free_cmd() callers
Date: Thu, 26 Jul 2018 17:10:20 +0000 [thread overview]
Message-ID: <2786ae3d77b99be8c6f384fbab12be357f858a15.camel@wdc.com> (raw)
In-Reply-To: <20180622215307.8758-14-bart.vanassche@wdc.com>
On Thu, 2018-07-26 at 16:42 +-0530, Varun Prakash wrote:
+AD4- cxgbit driver is not working with this patch as transport+AF8-free+AF8-pages()
+AD4- is called before calling conn-+AD4-conn+AF8-transport-+AD4-iscsit+AF8-release+AF8-cmd(), cxgbit
+AD4- driver calls dma+AF8-unmap+AF8-sg() in -+AD4-iscsit+AF8-release+AF8-cmd(), transport+AF8-free+AF8-pages()
+AD4- frees the scatterlist pages so dma unmap will not work.
+AD4-
+AD4- cxgbit driver needs a callback before target frees the pages
+AD4- so that it can dma unmap.
+AD4-
+AD4- We can remove -+AD4-iscsit+AF8-release+AF8-cmd() from +AF8AXw-iscsit+AF8-free+AF8-cmd() and call it
+AD4- directly from iscsit+AF8-free+AF8-cmd(), iscsit+AF8-aborted+AF8-task().
Hello Varun,
Thank you for your report. Since no other patches in this series depend on
this patch, I will send a revert.
Bart.
prev parent reply other threads:[~2018-07-26 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 21:53 [PATCH 13/20] target/iscsi: Reduce number of __iscsit_free_cmd() callers Bart Van Assche
2018-07-26 11:24 ` Varun Prakash
2018-07-26 17:10 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2786ae3d77b99be8c6f384fbab12be357f858a15.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).