From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D27FC433F5 for ; Wed, 18 May 2022 22:41:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230144AbiERWlL (ORCPT ); Wed, 18 May 2022 18:41:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230149AbiERWk6 (ORCPT ); Wed, 18 May 2022 18:40:58 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 524563AA79 for ; Wed, 18 May 2022 15:40:57 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id s14so3124541plk.8 for ; Wed, 18 May 2022 15:40:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=6CjLHJv2KA3UYpol8fjDDq5hkiBotVVzrhywge1qyNU=; b=wrJMFTIQ7Yp9Uql3VLw0P3eZsDs+b1JV9KcU/0cWmfEKtzb2nHz9qQOWcknqiv3wB6 Qe/tgV7Wd1ZHgM0PLCX4x70ixWK4nzzI8BoHFoJI7M5IVH+dxrvEfNoN7lwgKCD2f3s1 SssvyCbsFzUf3QgcSJFKnLglCQxAspEBBcIEcsJDQCshhG6gmosFUSSFrwSOE+2aeTrU 2lNPrBXDbYcs5PXq5jKYOuXIF1vCRi6YBouhmgTOE0bqz//uobUJex8BrlGWvPJWaR5i sNQ5I6zJ8fIjyybnFPYO1nhn+R5wcXeiyVTVwrufjzrTk7Hnrt7K/zVniZVpM1tdT3X9 TXQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=6CjLHJv2KA3UYpol8fjDDq5hkiBotVVzrhywge1qyNU=; b=grfs3bn3rVO733t/Exoj4s8flQqGsdfYDNUHKH/q5BQti3wEgcGV7+Z2gkzL6gME4/ HXITw7ZjGQYIqB9wRtozyWqfalVm4nraVdd8ib0yD+Ucnu7Cc2T9ONGA0Vl45YcOJOkt MhS7XuTfGxxSgBAmUVru+n/0mY4utsaUtchvn+Y7uGBM8vfRoK3Je/FRyC1KIPWSOlNr IXzBzqzI43olUcNgxeRlMKt2zAtU9PfzUzK2bApNRrBlR9xfRq/tJUaSGuh39h9yIQ41 A6kmYUZtHdMbvNZvGCdsdSBT8Vo8LpsnvTxyr8CJowfOYXQjFyyHqssI2fFh28jJ2czt lEcw== X-Gm-Message-State: AOAM5336u6+58x8yTAcrJOz323rb4mTz2gNvsUXD0IWQf2prygv8SAxj 9LicV3VfsA17CAJQoUxwihs/qw== X-Google-Smtp-Source: ABdhPJzs5D3xiswFdU/ktExKQiuNvoDQe4ombx0sc+ixFqOYLAZByoojFMvCFdJR/wrJj7TUPZJQmg== X-Received: by 2002:a17:90a:940d:b0:1df:359b:2f9e with SMTP id r13-20020a17090a940d00b001df359b2f9emr2261914pjo.235.1652913656802; Wed, 18 May 2022 15:40:56 -0700 (PDT) Received: from [192.168.1.100] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id a1-20020a1709027e4100b0015e8d4eb277sm2151000pln.193.2022.05.18.15.40.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 May 2022 15:40:56 -0700 (PDT) Message-ID: <28682d9a-ac58-ea19-6d51-73fbd87bfb5e@kernel.dk> Date: Wed, 18 May 2022 16:40:55 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: cleanup blk_execute_rq* Content-Language: en-US To: Christoph Hellwig Cc: Ming Lei , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org References: <20220517064901.3059255-1-hch@lst.de> From: Jens Axboe In-Reply-To: <20220517064901.3059255-1-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org On 5/17/22 12:48 AM, Christoph Hellwig wrote: > Hi Jens, > > this series cleans up the blk_execute_rq* helpers. It simplifies the > plugging mess a bit, fixes the sparse __bitwise warnings and simplifies > the blk_execute_rq_nowait API a bit. Looks good to me, but let's do this series post flushing out the initial bits. It ends up depending on the passthrough changes, yet also conflicts with the nvme changes on the driver side. -- Jens Axboe