From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH 04/15] target/iscsi: move session_index to common se_session
Date: Thu, 19 Jul 2018 15:23:33 +0000 [thread overview]
Message-ID: <3b18d0ff1b32155a9a936c42979a4341aa48a961.camel@wdc.com> (raw)
In-Reply-To: <1531696591-8558-5-git-send-email-mchristi@redhat.com>
On Wed, 2018-07-18 at 22:47 -0500, Mike Christie wrote:
+AD4- Hey Bart, I looked into this some more and this value is also being used
+AD4- as the scsiAttIntrPortIndex. For that use, does it need to be unique
+AD4- across a target when the target has multiple ports?
+AD4-
+AD4- So I think it needs to be on the se+AF8-wwn right?
Hello Mike,
I think the best solution would be to decouple the session index that is used
to export session information through configfs from the session index used by
the SCSI-MIB (scsiAttIntrPortIndex). That approach would allow to make both
indexes consecutive integers in all cases for both interfaces. However, neither
configfs nor the SCSI-MIB requires that session indexes are consecutive
integers. So I think moving se+AF8-sess+AF8-idr+AF8-lock and se+AF8-sess+AF8-idr into struct
se+AF8-wwn is fine.
Bart.
prev parent reply other threads:[~2018-07-19 15:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-15 23:16 [PATCH 04/15] target/iscsi: move session_index to common se_session Mike Christie
2018-07-18 22:19 ` Bart Van Assche
2018-07-19 0:15 ` Mike Christie
2018-07-19 3:47 ` Mike Christie
2018-07-19 15:23 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b18d0ff1b32155a9a936c42979a4341aa48a961.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).