From: Mike Christie <michael.christie@oracle.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: stefanha@redhat.com, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 1/1] vhost scsi: fix lun reset completion handling
Date: Wed, 18 Nov 2020 10:18:58 -0600 [thread overview]
Message-ID: <57a25e88-e94f-02e6-031c-cbe5ef086229@oracle.com> (raw)
In-Reply-To: <20201118035452-mutt-send-email-mst@kernel.org>
On 11/18/20 2:56 AM, Michael S. Tsirkin wrote:
> On Wed, Nov 18, 2020 at 12:24:20AM -0600, Mike Christie wrote:
>> vhost scsi owns the scsi se_cmd but lio frees the se_cmd->se_tmr
>> before calling release_cmd, so while with normal cmd completion we
>> can access the se_cmd from the vhost work, we can't do the same with
>> se_cmd->se_tmr. This has us copy the tmf response in
>> vhost_scsi_queue_tm_rsp to our internal vhost-scsi tmf struct for
>> when it gets sent to the guest from our worker thread.
>>
>> Signed-off-by: Mike Christie <michael.christie@oracle.com>
>
> Is this a fix for
> vhost scsi: Add support for LUN resets.
>
> If so pls add a Fixes: tag.
>
It is. Ok, will resend.
prev parent reply other threads:[~2020-11-18 16:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 6:24 [PATCH 1/1] vhost scsi: fix lun reset completion handling Mike Christie
2020-11-18 8:51 ` Stefan Hajnoczi
2020-11-18 8:56 ` Michael S. Tsirkin
2020-11-18 16:18 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57a25e88-e94f-02e6-031c-cbe5ef086229@oracle.com \
--to=michael.christie@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mst@redhat.com \
--cc=stefanha@redhat.com \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).