* [PATCH] target/tcmu: Use macro to call container_of in tcmu_cmd_time_out_show
@ 2017-09-15 5:44 Kenjiro Nakayama
2017-09-16 0:47 ` Mike Christie
0 siblings, 1 reply; 2+ messages in thread
From: Kenjiro Nakayama @ 2017-09-15 5:44 UTC (permalink / raw)
To: target-devel
This patch makes a tiny change that using TCMU_DEV in
tcmu_cmd_time_out_show so it is consistent with other functions.
Signed-off-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
---
drivers/target/target_core_user.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
index 942d094269fb..0705648acba3 100644
--- a/drivers/target/target_core_user.c
+++ b/drivers/target/target_core_user.c
@@ -1734,8 +1734,7 @@ static ssize_t tcmu_cmd_time_out_show(struct config_item *item, char *page)
{
struct se_dev_attrib *da = container_of(to_config_group(item),
struct se_dev_attrib, da_group);
- struct tcmu_dev *udev = container_of(da->da_dev,
- struct tcmu_dev, se_dev);
+ struct tcmu_dev *udev = TCMU_DEV(da->da_dev);
return snprintf(page, PAGE_SIZE, "%lu\n", udev->cmd_time_out / MSEC_PER_SEC);
}
--
2.13.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] target/tcmu: Use macro to call container_of in tcmu_cmd_time_out_show
2017-09-15 5:44 [PATCH] target/tcmu: Use macro to call container_of in tcmu_cmd_time_out_show Kenjiro Nakayama
@ 2017-09-16 0:47 ` Mike Christie
0 siblings, 0 replies; 2+ messages in thread
From: Mike Christie @ 2017-09-16 0:47 UTC (permalink / raw)
To: target-devel
On 09/15/2017 12:44 AM, Kenjiro Nakayama wrote:
> This patch makes a tiny change that using TCMU_DEV in
> tcmu_cmd_time_out_show so it is consistent with other functions.
>
> Signed-off-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
> ---
> drivers/target/target_core_user.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
> index 942d094269fb..0705648acba3 100644
> --- a/drivers/target/target_core_user.c
> +++ b/drivers/target/target_core_user.c
> @@ -1734,8 +1734,7 @@ static ssize_t tcmu_cmd_time_out_show(struct config_item *item, char *page)
> {
> struct se_dev_attrib *da = container_of(to_config_group(item),
> struct se_dev_attrib, da_group);
> - struct tcmu_dev *udev = container_of(da->da_dev,
> - struct tcmu_dev, se_dev);
> + struct tcmu_dev *udev = TCMU_DEV(da->da_dev);
>
> return snprintf(page, PAGE_SIZE, "%lu\n", udev->cmd_time_out / MSEC_PER_SEC);
> }
>
Reviewed-by: Mike Christie <mchristi@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-16 0:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-15 5:44 [PATCH] target/tcmu: Use macro to call container_of in tcmu_cmd_time_out_show Kenjiro Nakayama
2017-09-16 0:47 ` Mike Christie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).