From: Mike Christie <mchristi@redhat.com>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH 3/3] tcmu: add module wide block/reset_netlink support
Date: Fri, 22 Jun 2018 04:06:24 +0000 [thread overview]
Message-ID: <5B2C75C0.5000100@redhat.com> (raw)
In-Reply-To: <1529639560-9429-4-git-send-email-mchristi@redhat.com>
On 06/21/2018 10:52 PM, Mike Christie wrote:
> +static int tcmu_set_block_netlink(const char *str,
> + const struct kernel_param *kp)
> +{
> + int ret;
> + u8 val;
> +
> + ret = kstrtou8(str, 0, &val);
> + if (ret < 0)
> + return ret;
> +
> + if (val > 1 || val < 0) {
Darn. I meant to send a different version of the patch where it did
if (val != 1) {
since its a unsigned value.
I will resend this patch after you guys review it.
prev parent reply other threads:[~2018-06-22 4:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 3:52 [PATCH 3/3] tcmu: add module wide block/reset_netlink support Mike Christie
2018-06-22 4:06 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B2C75C0.5000100@redhat.com \
--to=mchristi@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).