From: Mike Christie <mchristi@redhat.com>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH 0/3] target: minor iSCSI parameter parsing fixes
Date: Mon, 21 Oct 2019 16:06:18 +0000 [thread overview]
Message-ID: <5DADD77A.6010903@redhat.com> (raw)
In-Reply-To: <20190912095547.22427-1-ddiss@suse.de>
On 09/12/2019 04:55 AM, David Disseldorp wrote:
> This patchset includes some minor fixes for parsing iSCSI CHAP_A and
> SendTargets fields. Patch 1/3 was already submitted and reviewed by
> Lee.
> I used the following libiscsi hacks to test for these bugs:
> https://github.com/ddiss/libiscsi/commits/bogus_chap_a
> https://github.com/ddiss/libiscsi/commits/bogus_sendtarget_key
> https://github.com/ddiss/libiscsi/commits/bogus_sendtarget_val
> I'll work on turning these into propper libiscsi regression tests
> (pending https://github.com/sahlberg/libiscsi/issues/297).
>
> Cheers, David
>
> drivers/target/iscsi/iscsi_target.c | 14 ++++++--------
> drivers/target/iscsi/iscsi_target_auth.c | 2 +-
> drivers/target/iscsi/iscsi_target_parameters.h | 3 ---
> 3 files changed, 7 insertions(+), 12 deletions(-)
>
Reviewed-by: Mike Christie <mchristi@redhat.com>
next prev parent reply other threads:[~2019-10-21 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 9:55 [PATCH 0/3] target: minor iSCSI parameter parsing fixes David Disseldorp
2019-10-21 16:06 ` Mike Christie [this message]
2019-10-23 2:14 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5DADD77A.6010903@redhat.com \
--to=mchristi@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox