From: Bart Van Assche <bvanassche@acm.org>
To: Dmitry Bogdanov <d.bogdanov@yadro.com>,
Martin Petersen <martin.petersen@oracle.com>,
target-devel@vger.kernel.org
Cc: linux-scsi@vger.kernel.org, linux@yadro.com
Subject: Re: [PATCH 4/4] target: core: new key must be used for moved PR
Date: Wed, 7 Sep 2022 09:19:46 -0700 [thread overview]
Message-ID: <73091ce3-5412-b3f8-94c5-c6224ffcc08c@acm.org> (raw)
In-Reply-To: <20220907135851.3756-5-d.bogdanov@yadro.com>
On 9/7/22 06:58, Dmitry Bogdanov wrote:
> + } else {
> + /*
> + * e) Retain the reservation key specified in the SERVICE ACTION
> + * RESERVATION KEY field and associated information;
> + */
> + dest_pr_reg->pr_res_key = sa_res_key;
> }
The indentation of the new comment looks wrong to me. Please fix.
Thanks,
Bart.
next prev parent reply other threads:[~2022-09-07 16:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 13:58 [PATCH 0/4] target: fix bugs in Persistent Reservations Dmitry Bogdanov
2022-09-07 13:58 ` [PATCH 1/4] target: core: fix preempt and abort for allreg res Dmitry Bogdanov
2022-09-07 16:18 ` Bart Van Assche
2022-09-08 8:34 ` Dmitry Bogdanov
2022-09-07 13:58 ` [PATCH 2/4] target: core: fix memory leak in preempt_and_abort Dmitry Bogdanov
2022-09-07 13:58 ` [PATCH 3/4] target: core: abort all preempted regs if requested Dmitry Bogdanov
2022-09-07 13:58 ` [PATCH 4/4] target: core: new key must be used for moved PR Dmitry Bogdanov
2022-09-07 16:19 ` Bart Van Assche [this message]
2022-09-08 8:39 ` Dmitry Bogdanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73091ce3-5412-b3f8-94c5-c6224ffcc08c@acm.org \
--to=bvanassche@acm.org \
--cc=d.bogdanov@yadro.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@yadro.com \
--cc=martin.petersen@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).