Re: [PATCH] scsi: target: core: add missing file_{start,end}_write()

[Amir Goldstein <amir73il@gmail.com>]

On Thu, Nov 23, 2023 at 10:04 PM Jens Axboe <axboe@kernel.dk> wrote:
>
> On 11/23/23 2:20 AM, Amir Goldstein wrote:
> > The callers of vfs_iter_write() are required to hold file_start_write().
> > file_start_write() is a no-op for the S_ISBLK() case, but it is really
> > needed when the backing file is a regular file.
> >
> > We are going to move file_{start,end}_write() into vfs_iter_write(), but
> > we need to fix this first, so that the fix could be backported to stable
> > kernels.
>
> Reviewed-by: Jens Axboe <axboe@kernel.dk>
>

Christian,

Shall we just stash this at the bottom of vfs.rw and fixup
"move file_{start,end}_write() into vfs_iter_write()" patch?

I see no strong reason to expedite a fix for something rare
that has been broken for a long time.

If Martin decides to expedite it, we can alway rebase vfs.rw
once the fix is merged to master.

Thanks,
Amir.