From: Christoph Hellwig <hch@infradead.org>
To: Mike Christie <michael.christie@oracle.com>
Cc: Nikos Tsironis <ntsironis@arrikto.com>,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org
Subject: Re: [PATCH] tcm_loop: Increase maximum request size
Date: Wed, 7 Dec 2022 10:35:23 -0800 [thread overview]
Message-ID: <Y5Dc66mOzBfBhUGY@infradead.org> (raw)
In-Reply-To: <ed3e5f22-dd2c-2952-dc7e-c47bccf66611@oracle.com>
On Wed, Dec 07, 2022 at 12:29:56PM -0600, Mike Christie wrote:
> I think you need to make this configurable.
>
> If you use loop with pscsi, then the sgl that loop now gets might be too
> big for the backend device so we now fail in:
>
> pscsi_map_sg -> blk_rq_append_bio -> ll_back_merge_fn
>
> So some users might be relying on the smaller limit.
Note that this could happen even now, you just need sufficiently
horrible hardware to pass through for it. But yes, for pscsi
this needs to look at the underlying device, and increasing the
limit might be a good point to do that. I'm not sure it's worth
to add user configuration, though.
next prev parent reply other threads:[~2022-12-07 18:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 11:55 [PATCH] tcm_loop: Increase maximum request size Nikos Tsironis
2022-10-02 21:09 ` Bart Van Assche
2022-10-12 14:19 ` Nikos Tsironis
2022-10-12 16:32 ` Bart Van Assche
2022-12-07 10:29 ` Nikos Tsironis
2022-12-07 18:29 ` Mike Christie
2022-12-07 18:35 ` Christoph Hellwig [this message]
2022-12-19 14:39 ` Nikos Tsironis
2022-12-19 18:49 ` Mike Christie
2022-12-21 8:30 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5Dc66mOzBfBhUGY@infradead.org \
--to=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=ntsironis@arrikto.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).