From: Leon Romanovsky <leon@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-kernel@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>,
Selvin Xavier <selvin.xavier@broadcom.com>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Bart Van Assche <bvanassche@acm.org>,
linux-rdma@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH] IB: move from strlcpy with unused retval to strscpy
Date: Sun, 21 Aug 2022 14:18:11 +0300 [thread overview]
Message-ID: <YwIUc7E18FexunJB@unreal> (raw)
In-Reply-To: <20220818210018.6841-1-wsa+renesas@sang-engineering.com>
On Thu, Aug 18, 2022 at 11:00:18PM +0200, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
>
> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/infiniband/core/cma_configfs.c | 2 +-
> drivers/infiniband/core/device.c | 4 ++--
> drivers/infiniband/hw/bnxt_re/main.c | 2 +-
> drivers/infiniband/hw/hfi1/file_ops.c | 2 +-
> drivers/infiniband/hw/hfi1/verbs.c | 2 +-
> drivers/infiniband/hw/mthca/mthca_cmd.c | 2 +-
> drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 2 +-
> drivers/infiniband/hw/qib/qib_iba7322.c | 2 +-
> drivers/infiniband/ulp/ipoib/ipoib_ethtool.c | 4 ++--
> drivers/infiniband/ulp/opa_vnic/opa_vnic_ethtool.c | 4 ++--
> drivers/infiniband/ulp/srpt/ib_srpt.c | 2 +-
> 11 files changed, 14 insertions(+), 14 deletions(-)
You forgot to change strlcpy in include/rdma/rdma_vt.h file.
I changed locally and applied to -next.
Thanks
prev parent reply other threads:[~2022-08-21 11:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 21:00 [PATCH] IB: move from strlcpy with unused retval to strscpy Wolfram Sang
2022-08-21 11:18 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwIUc7E18FexunJB@unreal \
--to=leon@kernel.org \
--cc=bvanassche@acm.org \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=selvin.xavier@broadcom.com \
--cc=target-devel@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).