From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5554AC00140 for ; Sun, 21 Aug 2022 11:18:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229603AbiHULSW (ORCPT ); Sun, 21 Aug 2022 07:18:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229566AbiHULSV (ORCPT ); Sun, 21 Aug 2022 07:18:21 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD722643F; Sun, 21 Aug 2022 04:18:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 86D75B80CAC; Sun, 21 Aug 2022 11:18:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7336C433D6; Sun, 21 Aug 2022 11:18:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661080696; bh=ptHOrY6H/u2M8gvWUkoZP/1haNUm/UVGhD3B1HMsr8E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pOPbY0XfVrNLb9iaanR876q8f08y8gyXGNkotpb79QcY6qjJmNFB4bVfEbodGBKXO tbXcas9Y0Dz+sVfwjcaGZRIzlSVIjrQP4Gga8kG+Y0REXr4MKb/lx6AyUMK5FXXe+Q JK9FvVoUHm0pdKbcWM9Db11Nbbnu6Gs5znb8bh1Z90M9+nSpr343uKFCikD5osJGUV +ig/3HZbNAxhu92wyRoNfv/PjsADY5B47b6gzoTR70Ll4tAJc5595aH6whYXwUPbXJ Uii7LNUr+dKFoMd6Z5gNwGdoCqqIjkbRbFFYSra8WnbMYQ6ovxmLTjiYQHQKq+Tv+k 6uLklpwb4krNQ== Date: Sun, 21 Aug 2022 14:18:11 +0300 From: Leon Romanovsky To: Wolfram Sang Cc: linux-kernel@vger.kernel.org, Jason Gunthorpe , Selvin Xavier , Dennis Dalessandro , Bart Van Assche , linux-rdma@vger.kernel.org, target-devel@vger.kernel.org Subject: Re: [PATCH] IB: move from strlcpy with unused retval to strscpy Message-ID: References: <20220818210018.6841-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220818210018.6841-1-wsa+renesas@sang-engineering.com> Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org On Thu, Aug 18, 2022 at 11:00:18PM +0200, Wolfram Sang wrote: > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. > > Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ > Signed-off-by: Wolfram Sang > --- > drivers/infiniband/core/cma_configfs.c | 2 +- > drivers/infiniband/core/device.c | 4 ++-- > drivers/infiniband/hw/bnxt_re/main.c | 2 +- > drivers/infiniband/hw/hfi1/file_ops.c | 2 +- > drivers/infiniband/hw/hfi1/verbs.c | 2 +- > drivers/infiniband/hw/mthca/mthca_cmd.c | 2 +- > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 2 +- > drivers/infiniband/hw/qib/qib_iba7322.c | 2 +- > drivers/infiniband/ulp/ipoib/ipoib_ethtool.c | 4 ++-- > drivers/infiniband/ulp/opa_vnic/opa_vnic_ethtool.c | 4 ++-- > drivers/infiniband/ulp/srpt/ib_srpt.c | 2 +- > 11 files changed, 14 insertions(+), 14 deletions(-) You forgot to change strlcpy in include/rdma/rdma_vt.h file. I changed locally and applied to -next. Thanks