From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "keescook@chromium.org" <keescook@chromium.org>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "vinod.koul@intel.com" <vinod.koul@intel.com>,
"david.kershner@unisys.com" <david.kershner@unisys.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"nab@linux-iscsi.org" <nab@linux-iscsi.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"hch@lst.de" <hch@lst.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"manoj@linux.vnet.ibm.com" <manoj@linux.vnet.ibm.com>,
"sdharia@codeaurora.org" <sdharia@codeaurora.org>,
"jgross@suse.com" <jgross@suse.com>,
"cyrille.pitchen@free-electrons.com"
<cyrille.pitchen@free-electrons.com>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
"pombredanne@nexb.com" <pombredanne@nexb.com>,
"bp@alien8.de" <bp@alien8.de>,
"mrochs@linux.vnet.ibm.com" <mrochs@linux.vnet.ibm.com>,
"tj@kernel.org" <tj@kernel.org>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"sboyd@codeaurora.org" <sboyd@codeaurora.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ukrishn@linux.vnet.ibm.com" <ukrishn@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 3/9] scsi: build scsi_common.o for all scsi passthrough request users
Date: Tue, 31 Jul 2018 20:01:16 +0000 [thread overview]
Message-ID: <a5b545eade66f95c9a9ecf37676306a8d395187c.camel@wdc.com> (raw)
In-Reply-To: <20180731195155.46664-4-keescook@chromium.org>
On Tue, 2018-07-31 at 12:51 -0700, Kees Cook wrote:
+AD4- diff --git a/drivers/Makefile b/drivers/Makefile
+AD4- index 24cd47014657..a6abd7a856c6 100644
+AD4- --- a/drivers/Makefile
+AD4- +-+-+- b/drivers/Makefile
+AD4- +AEAAQA- -76,7 +-76,7 +AEAAQA- obj-+ACQ-(CONFIG+AF8-DMA+AF8-SHARED+AF8-BUFFER) +-+AD0- dma-buf/
+AD4- obj-+ACQ-(CONFIG+AF8-NUBUS) +-+AD0- nubus/
+AD4- obj-y +-+AD0- macintosh/
+AD4- obj-+ACQ-(CONFIG+AF8-IDE) +-+AD0- ide/
+AD4- -obj-+ACQ-(CONFIG+AF8-SCSI) +-+AD0- scsi/
+AD4- +-obj-y +-+AD0- scsi/
+AD4- obj-y +-+AD0- nvme/
+AD4- obj-+ACQ-(CONFIG+AF8-ATA) +-+AD0- ata/
+AD4- obj-+ACQ-(CONFIG+AF8-TARGET+AF8-CORE) +-+AD0- target/
The above change not only selects scsi+AF8-common.o but also the following object
files: scsi.o hosts.o scsi+AF8-ioctl.o scsicam.o scsi+AF8-error.o scsi+AF8-lib.o scsi+AF8-scan.o
scsi+AF8-sysfs.o scsi+AF8-devinfo.o scsi+AF8-trace.o scsi+AF8-logging.o. That is a change that
has not been mentioned in the patch description. That makes me wonder whether
this is an intended change? Wouldn't a cleaner solution have been to move
scsi+AF8-common.c into a new directory?
Bart.
next prev parent reply other threads:[~2018-07-31 20:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 19:51 [PATCH v2 0/9] block: Consolidate scsi sense buffer usage Kees Cook
2018-07-31 19:51 ` [PATCH v2 1/9] ide-cd: Drop unused sense buffers Kees Cook
2018-07-31 21:29 ` David Miller
2018-07-31 19:51 ` [PATCH v2 2/9] scsi: cxlflash: " Kees Cook
2018-07-31 19:51 ` [PATCH v2 3/9] scsi: build scsi_common.o for all scsi passthrough request users Kees Cook
2018-07-31 20:01 ` Bart Van Assche [this message]
2018-07-31 20:12 ` hch
2018-07-31 20:18 ` Bart Van Assche
2018-08-01 19:50 ` Kees Cook
2018-07-31 19:51 ` [PATCH v2 4/9] target: don't depend on SCSI Kees Cook
2018-08-06 23:38 ` Randy Dunlap
2018-08-06 23:59 ` Kees Cook
2018-08-07 0:52 ` Randy Dunlap
2018-08-07 5:44 ` Christoph Hellwig
2018-07-31 19:51 ` [PATCH v2 5/9] block: Switch struct packet_command to use struct scsi_sense_hdr Kees Cook
2018-08-01 8:22 ` Christoph Hellwig
2018-07-31 19:51 ` [PATCH v2 6/9] ide-cd: Remove redundant sense buffer Kees Cook
2018-07-31 21:30 ` David Miller
2018-08-01 8:23 ` Christoph Hellwig
2018-07-31 19:51 ` [PATCH v2 7/9] cdrom: Use struct scsi_sense_hdr internally Kees Cook
2018-08-01 8:24 ` Christoph Hellwig
2018-07-31 19:51 ` [PATCH v2 8/9] libata-scsi: Move sense buffers onto stack Kees Cook
2018-08-01 8:24 ` Christoph Hellwig
2018-08-01 15:45 ` Tejun Heo
2018-07-31 19:51 ` [PATCH v2 9/9] scsi: Check sense buffer size at build time Kees Cook
2018-08-01 8:25 ` Christoph Hellwig
2018-08-02 20:21 ` [PATCH v2 0/9] block: Consolidate scsi sense buffer usage Martin K. Petersen
2018-08-02 21:24 ` Jens Axboe
2018-08-02 21:56 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5b545eade66f95c9a9ecf37676306a8d395187c.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@kernel.dk \
--cc=bp@alien8.de \
--cc=cyrille.pitchen@free-electrons.com \
--cc=davem@davemloft.net \
--cc=david.kershner@unisys.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=jgross@suse.com \
--cc=keescook@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manoj@linux.vnet.ibm.com \
--cc=martin.petersen@oracle.com \
--cc=mrochs@linux.vnet.ibm.com \
--cc=nab@linux-iscsi.org \
--cc=pombredanne@nexb.com \
--cc=rdunlap@infradead.org \
--cc=sboyd@codeaurora.org \
--cc=sdharia@codeaurora.org \
--cc=target-devel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=ukrishn@linux.vnet.ibm.com \
--cc=vinod.koul@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).