* [PATCH v6 69/80] IB/srpt: docs: add a description for cq_size member [not found] <cover.1602589096.git.mchehab+huawei@kernel.org> @ 2020-10-13 11:54 ` Mauro Carvalho Chehab 2020-10-15 4:32 ` Bart Van Assche 0 siblings, 1 reply; 2+ messages in thread From: Mauro Carvalho Chehab @ 2020-10-13 11:54 UTC (permalink / raw) To: Linux Doc Mailing List Cc: Mauro Carvalho Chehab, Jonathan Corbet, Bart Van Assche, Doug Ledford, Jason Gunthorpe, Max Gurtovoy, Sagi Grimberg, Yamin Friedman, linux-kernel, linux-rdma, target-devel Changeset c804af2c1d31 ("IB/srpt: use new shared CQ mechanism") added a new member for struct srpt_rdma_ch, but didn't add the corresponding kernel-doc markup, as repoted when doing "make htmldocs": ./drivers/infiniband/ulp/srpt/ib_srpt.h:331: warning: Function parameter or member 'cq_size' not described in 'srpt_rdma_ch' Add a description for it. Fixes: c804af2c1d31 ("IB/srpt: use new shared CQ mechanism") Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> --- drivers/infiniband/ulp/srpt/ib_srpt.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.h b/drivers/infiniband/ulp/srpt/ib_srpt.h index 41435a699b53..e5d6af14d073 100644 --- a/drivers/infiniband/ulp/srpt/ib_srpt.h +++ b/drivers/infiniband/ulp/srpt/ib_srpt.h @@ -256,6 +256,7 @@ enum rdma_ch_state { * @rdma_cm: See below. * @rdma_cm.cm_id: RDMA CM ID associated with the channel. * @cq: IB completion queue for this channel. + * @cq_size: Size of the @cq pool. * @zw_cqe: Zero-length write CQE. * @rcu: RCU head. * @kref: kref for this channel. -- 2.26.2 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v6 69/80] IB/srpt: docs: add a description for cq_size member 2020-10-13 11:54 ` [PATCH v6 69/80] IB/srpt: docs: add a description for cq_size member Mauro Carvalho Chehab @ 2020-10-15 4:32 ` Bart Van Assche 0 siblings, 0 replies; 2+ messages in thread From: Bart Van Assche @ 2020-10-15 4:32 UTC (permalink / raw) To: Mauro Carvalho Chehab, Linux Doc Mailing List Cc: Jonathan Corbet, Doug Ledford, Jason Gunthorpe, Max Gurtovoy, Sagi Grimberg, Yamin Friedman, linux-kernel, linux-rdma, target-devel On 10/13/20 4:54 AM, Mauro Carvalho Chehab wrote: > Changeset c804af2c1d31 ("IB/srpt: use new shared CQ mechanism") > added a new member for struct srpt_rdma_ch, but didn't add the > corresponding kernel-doc markup, as repoted when doing > "make htmldocs": > ./drivers/infiniband/ulp/srpt/ib_srpt.h:331: warning: Function parameter or member 'cq_size' not described in 'srpt_rdma_ch' > > Add a description for it. > > Fixes: c804af2c1d31 ("IB/srpt: use new shared CQ mechanism") > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > --- > drivers/infiniband/ulp/srpt/ib_srpt.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.h b/drivers/infiniband/ulp/srpt/ib_srpt.h > index 41435a699b53..e5d6af14d073 100644 > --- a/drivers/infiniband/ulp/srpt/ib_srpt.h > +++ b/drivers/infiniband/ulp/srpt/ib_srpt.h > @@ -256,6 +256,7 @@ enum rdma_ch_state { > * @rdma_cm: See below. > * @rdma_cm.cm_id: RDMA CM ID associated with the channel. > * @cq: IB completion queue for this channel. > + * @cq_size: Size of the @cq pool. > * @zw_cqe: Zero-length write CQE. > * @rcu: RCU head. > * @kref: kref for this channel. That doesn't seem correct to me. My understanding is that cq_size is the number of CQEs in @cq. @cq is a completion queue and not a CQ pool. Bart. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-15 4:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1602589096.git.mchehab+huawei@kernel.org>
2020-10-13 11:54 ` [PATCH v6 69/80] IB/srpt: docs: add a description for cq_size member Mauro Carvalho Chehab
2020-10-15 4:32 ` Bart Van Assche
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).