From: Lee Duncan <lduncan@suse.com>
To: Mike Christie <mchristi@redhat.com>,
bvanassche@acm.org, bstroesser@ts.fujitsu.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH 02/15] target: separate acl name from port ids
Date: Wed, 13 May 2020 23:35:43 +0000 [thread overview]
Message-ID: <ebce879c-2187-4d10-9e7e-74d0a68aafbd@suse.com> (raw)
In-Reply-To: <20200510215744.21999-3-mchristi@redhat.com>
On 5/10/20 2:57 PM, Mike Christie wrote:
> The PGR code assumes the ACL name is going to be based on the SPC4
> transportID type of values. The problem is that for iSCSI we have an extra
> session id as part of the SCSI port id and some fabric modules support or
> would like to support non transportID values for the ACL name. For example,
> iSCSI and SRP would like to use the source address for the ACL name, but
> that is not a valud transportID value that you can get in a PGR request.
>
> This patch adds a new transport_id struct which maps to the SPC4
> transportID. In the future it will be used for PGR commands instead of the
> ACL name. In this patchset it is used to export the initiator info in the
> session's sysfs dir, so tools can display the info and daemons that execute
> commands like PGRs in userspace can build a session id to I_T nexus mapping.
>
> In this patch only srp is passing in different values for the transport id
> and acl name. The next patches will convert loop, scsi vhost and xen
> scsiback that are more complex due to their initiator name emulation.
>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: Juergen Gross <jgross@suse.com>
> Signed-off-by: Mike Christie <mchristi@redhat.com>
> ---
>
> V4:
> - Don't drop const char use. We still have target_setup_session allocate
> the transport_id struct, but because every uses format=0 we just need to
> pass in the transport_id's name.
>
> V3:
> - drop format
>
> drivers/infiniband/ulp/srpt/ib_srpt.c | 10 +++++---
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 4 +--
> drivers/scsi/qla2xxx/tcm_qla2xxx.c | 2 +-
> drivers/target/loopback/tcm_loop.c | 3 ++-
> drivers/target/sbp/sbp_target.c | 2 +-
> drivers/target/target_core_fabric_lib.c | 41 +++++++++++++++++++++++++++++++
> drivers/target/target_core_transport.c | 42 ++++++++++++++++++++++++--------
> drivers/target/tcm_fc/tfc_sess.c | 3 ++-
> drivers/usb/gadget/function/f_tcm.c | 3 ++-
> drivers/vhost/scsi.c | 1 +
> drivers/xen/xen-scsiback.c | 3 ++-
> include/target/target_core_base.h | 12 +++++++++
> include/target/target_core_fabric.h | 5 +++-
> 13 files changed, 108 insertions(+), 23 deletions(-)
>
Reviewed-by: Lee Duncan <lduncan@suse.com>
next prev parent reply other threads:[~2020-05-13 23:35 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 21:57 [PATCH v5 00/15] target: add sysfs support Mike Christie
2020-05-10 21:57 ` [PATCH 01/15] target: check enforce_pr_isids during registration Mike Christie
2020-05-11 6:08 ` Hannes Reinecke
2020-05-13 20:55 ` Lee Duncan
2020-05-10 21:57 ` [PATCH 02/15] target: separate acl name from port ids Mike Christie
2020-05-11 6:09 ` Hannes Reinecke
2020-05-13 23:35 ` Lee Duncan [this message]
2020-05-10 21:57 ` [PATCH 03/15] target: add helper to parse acl and transport name Mike Christie
2020-05-11 6:09 ` Hannes Reinecke
2020-05-11 18:22 ` Bodo Stroesser
2020-05-11 21:04 ` Mike Christie
2020-05-13 23:57 ` Lee Duncan
2020-05-10 21:57 ` [PATCH 04/15] tcm loop: use target_parse_emulated_name Mike Christie
2020-05-11 6:10 ` Hannes Reinecke
2020-05-13 23:59 ` Lee Duncan
2020-05-10 21:57 ` [PATCH 05/15] vhost scsi: " Mike Christie
2020-05-11 6:11 ` Hannes Reinecke
2020-05-10 21:57 ` [PATCH 06/15] xen scsiback: " Mike Christie
2020-05-11 6:11 ` Hannes Reinecke
2020-05-11 6:16 ` Jürgen Groß
2020-05-10 21:57 ` [PATCH 07/15] iscsi target: setup transport_id Mike Christie
2020-05-11 6:12 ` Hannes Reinecke
2020-05-10 21:57 ` [PATCH 08/15] target: use tpt_id in target_stat_iport_port_ident_show Mike Christie
2020-05-11 6:13 ` Hannes Reinecke
2020-05-10 21:57 ` [PATCH 09/15] target: drop sess_get_initiator_sid from PR code Mike Christie
2020-05-11 6:13 ` Hannes Reinecke
2020-05-10 21:57 ` [PATCH 10/15] target: drop sess_get_initiator_sid Mike Christie
2020-05-11 6:14 ` Hannes Reinecke
2020-05-10 21:57 ` [PATCH 11/15] target: add sysfs support Mike Christie
2020-05-11 6:21 ` Hannes Reinecke
2020-05-11 6:30 ` Greg Kroah-Hartman
2020-05-11 17:15 ` Mike Christie
2020-05-12 5:54 ` Greg Kroah-Hartman
2020-05-10 21:57 ` [PATCH 12/15] target: add sysfs session helper functions Mike Christie
2020-05-11 18:39 ` Bodo Stroesser
2020-05-11 19:21 ` Bart Van Assche
2020-05-11 20:16 ` Mike Christie
2020-05-12 11:19 ` Bodo Stroesser
2020-05-12 15:55 ` Mike Christie
2020-05-10 21:57 ` [PATCH 13/15] target: add target_setup_session sysfs support Mike Christie
2020-05-10 21:57 ` [PATCH 14/15] iscsi target: use session sysfs helpers Mike Christie
2020-05-10 21:57 ` [PATCH 15/15] target: drop sess_get_index Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebce879c-2187-4d10-9e7e-74d0a68aafbd@suse.com \
--to=lduncan@suse.com \
--cc=bstroesser@ts.fujitsu.com \
--cc=bvanassche@acm.org \
--cc=jasowang@redhat.com \
--cc=jgross@suse.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mchristi@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).