From: Mike Christie <michael.christie@oracle.com>
To: David Disseldorp <ddiss@suse.de>, target-devel@vger.kernel.org
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2 0/5] scsi: target: COMPARE AND WRITE miscompare sense
Date: Tue, 27 Oct 2020 05:49:23 +0000 [thread overview]
Message-ID: <ec78c756-6abd-32a8-a7d3-1c7788fa57d3@oracle.com> (raw)
In-Reply-To: <20201026190646.8727-1-ddiss@suse.de>
On 10/26/20 2:06 PM, David Disseldorp wrote:
> This patchset adds missing functionality to return the offset of
> non-matching read/compare data in the sense INFORMATION field on
> COMPARE AND WRITE miscompare.
>
> The functionality can be tested using the libiscsi
> CompareAndWrite.MiscompareSense test proposed via:
> https://urldefense.com/v3/__https://github.com/sahlberg/libiscsi/pull/344__;!!GqivPVa7Brio!LJ-un7MDdHXhZgIK1qgvDgza2El16FK-T_4oDi6VqM0CzetAV9pGHDvLDrZUkITTHxhO$
>
> Changes since v1:
> - drop unnecessary WARN_ON()
> - fix two checkpatch warnings
> - drop single-use nlbas variable
> - avoid compare_len recalculation
>
> Cheers, David
>
> drivers/target/target_core_sbc.c | 137 +++++++++++++++----------
> drivers/target/target_core_transport.c | 33 +++---
> include/target/target_core_base.h | 2 +-
> lib/scatterlist.c | 2 +-
> 4 files changed, 102 insertions(+), 72 deletions(-)
Reviewed-by: Mike Christie <michael.christie@oracle.com>
next prev parent reply other threads:[~2020-10-27 5:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 19:06 [PATCH v2 0/5] scsi: target: COMPARE AND WRITE miscompare sense David Disseldorp
2020-10-26 19:06 ` [PATCH v2 1/5] lib/scatterlist: use consistent sg_copy_buffer() return type David Disseldorp
2020-10-26 20:50 ` Douglas Gilbert
2020-10-26 21:05 ` David Disseldorp
2020-10-26 19:06 ` [PATCH v2 2/5] scsi: target: rename struct sense_info to sense_detail David Disseldorp
2020-10-26 19:06 ` [PATCH v2 3/5] scsi: target: rename cmd.bad_sector to cmd.sense_info David Disseldorp
2020-10-26 19:06 ` [PATCH v2 4/5] scsi: target: split out COMPARE AND WRITE memcmp into helper David Disseldorp
2020-10-26 19:06 ` [PATCH v2 5/5] scsi: target: return COMPARE AND WRITE miscompare offsets David Disseldorp
2020-10-27 5:49 ` Mike Christie [this message]
2020-10-27 9:57 ` [PATCH v2 0/5] scsi: target: COMPARE AND WRITE miscompare sense David Disseldorp
2020-10-30 2:02 ` Martin K. Petersen
2020-10-30 2:06 ` Martin K. Petersen
2020-10-30 14:06 ` David Disseldorp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec78c756-6abd-32a8-a7d3-1c7788fa57d3@oracle.com \
--to=michael.christie@oracle.com \
--cc=ddiss@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).