From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Duncan Date: Wed, 13 May 2020 23:57:36 +0000 Subject: Re: [PATCH 03/15] target: add helper to parse acl and transport name Message-Id: List-Id: References: <20200510215744.21999-1-mchristi@redhat.com> <20200510215744.21999-4-mchristi@redhat.com> In-Reply-To: <20200510215744.21999-4-mchristi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mike Christie , bvanassche@acm.org, bstroesser@ts.fujitsu.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Cc: "Michael S . Tsirkin" , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Juergen Gross On 5/10/20 2:57 PM, Mike Christie wrote: > The drivers that emulate the initiator port id (loop, scsi vhost, xen scsiback) > do almost the extact same parsing when making their I_T_nexus. This adds a > helper that parses out the acl name and port name from the user buffer, so > these types of drivers drop prefixes like "naa." when they need to for the > SCSI SPC4 TransportID SAS address, but then keep it for the LIO ACL name. > > The next patches will then convert those drivers. > > Cc: Michael S. Tsirkin > Cc: Jason Wang > Cc: Paolo Bonzini > Cc: Stefan Hajnoczi > Cc: Juergen Gross > Signed-off-by: Mike Christie > --- > drivers/target/target_core_fabric_lib.c | 73 +++++++++++++++++++++++++++++++++ > include/target/target_core_fabric.h | 2 + > 2 files changed, 75 insertions(+) > ... Reviewed-by: Lee Duncan