From: Bart Van Assche <bvanassche@acm.org>
To: target-devel@vger.kernel.org,
James Bottomley <jejb@linux.vnet.ibm.com>,
Hannes Reinecke <hare@suse.com>,
Mike Christie <michael.christie@oracle.com>
Subject: About the tcm_fc FCoE target driver
Date: Mon, 4 Jan 2021 07:51:59 -0800 [thread overview]
Message-ID: <f5808b3e-0434-9d8b-93fe-94d48d657926@acm.org> (raw)
Hi,
My understanding is that the ft_queue_data_in() function in the tcm_fc
driver gets called while processing SCSI READ commands. That function queues
data for sending by calling fc_seq_send(). The FCoE driver translates that
call into a dev_queue_xmit(skb) which sends the data asynchronously.
ft_queue_data_in() frees the data buffer synchronously from inside
ft_queue_status(). I believe that this race condition can trigger data
corruption. Since nobody ever reported this race condition, does this mean
that the FCoE target driver has no users and hence that it can be removed
from the kernel tree?
Thanks,
Bart.
next reply other threads:[~2021-01-04 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 15:51 Bart Van Assche [this message]
2021-01-04 16:06 ` About the tcm_fc FCoE target driver James Bottomley
2021-01-04 17:04 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5808b3e-0434-9d8b-93fe-94d48d657926@acm.org \
--to=bvanassche@acm.org \
--cc=hare@suse.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=michael.christie@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).