From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH] target: Fix a pr_debug() argument
Date: Tue, 19 Nov 2019 05:32:57 +0000 [thread overview]
Message-ID: <yq1blt8ig6u.fsf@oracle.com> (raw)
In-Reply-To: <20191107215525.64415-1-bvanassche@acm.org>
Hi Bart!
> Print the string for which conversion failed instead of printing the
> function name twice.
What do you mean wrt. printing the function name twice?
> Cc: Christoph Hellwig <hch@lst.de>
> Fixes: 2650d71e244f ("target: move transport ID handling to the core")
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/target/target_core_fabric_lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/target/target_core_fabric_lib.c b/drivers/target/target_core_fabric_lib.c
> index 3c79411c4cd0..6b4b354c88aa 100644
> --- a/drivers/target/target_core_fabric_lib.c
> +++ b/drivers/target/target_core_fabric_lib.c
> @@ -118,7 +118,7 @@ static int srp_get_pr_transport_id(
> memset(buf + 8, 0, leading_zero_bytes);
> rc = hex2bin(buf + 8 + leading_zero_bytes, p, count);
> if (rc < 0) {
> - pr_debug("hex2bin failed for %s: %d\n", __func__, rc);
> + pr_debug("hex2bin failed for %s: %d\n", p, rc);
> return rc;
> }
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-11-19 5:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 21:55 [PATCH] target: Fix a pr_debug() argument Bart Van Assche
2019-11-19 5:32 ` Martin K. Petersen [this message]
2019-11-19 16:30 ` Bart Van Assche
2019-11-20 3:02 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1blt8ig6u.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox