From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bodo Stroesser <bstroesser@ts.fujitsu.com>
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
mchristi@redhat.com, martin.petersen@oracle.com
Subject: Re: [PATCH] target: tcmu: reset_ring should reset TCMU_DEV_BIT_BROKEN
Date: Mon, 13 Apr 2020 18:03:40 +0000 [thread overview]
Message-ID: <yq1ftd7xnyb.fsf@oracle.com> (raw)
In-Reply-To: <20200409101026.17872-1-bstroesser@ts.fujitsu.com> (Bodo Stroesser's message of "Thu, 9 Apr 2020 12:10:26 +0200")
Bodo,
> In case command ring buffer becomes inconsistent, tcmu sets device
> flag TCMU_DEV_BIT_BROKEN. If the bit is set, tcmu rejects new
> commands from lio core with TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE,
> and no longer processes completions from the ring. The reset_ring
> attribute can be used to completely clean up the command ring, so
> after reset_ring the ring no longer is inconsistent.
>
> Therefore reset_ring also should reset bit TCMU_DEV_BIT_BROKEN to
> allow normal processing.
Applied to 5.7/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2020-04-13 18:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 10:10 [PATCH] target: tcmu: reset_ring should reset TCMU_DEV_BIT_BROKEN Bodo Stroesser
2020-04-09 15:29 ` Mike Christie
2020-04-13 18:03 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1ftd7xnyb.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=bstroesser@ts.fujitsu.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox