* [PATCH 1/1] tcmu: Don't pass KERN_ERR to pr_err
@ 2018-06-26 16:47 Mike Christie
2018-06-26 16:55 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Mike Christie @ 2018-06-26 16:47 UTC (permalink / raw)
To: target-devel
Fix warning:
smatch warnings:
drivers/target/target_core_user.c:301 tcmu_genl_cmd_done() warn: KERN_*
level not at start of string
Signed-off-by: Mike Christie <mchristi@redhat.com>
---
drivers/target/target_core_user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
index 9555981..847707a 100644
--- a/drivers/target/target_core_user.c
+++ b/drivers/target/target_core_user.c
@@ -383,7 +383,7 @@ static int tcmu_genl_cmd_done(struct genl_info *info, int completed_cmd)
}
if (!udev) {
- pr_err(KERN_ERR "tcmu nl cmd %u/%d completion could not find device with dev id %u.\n",
+ pr_err("tcmu nl cmd %u/%d completion could not find device with dev id %u.\n",
completed_cmd, rc, dev_id);
ret = -ENODEV;
goto unlock;
--
2.7.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] tcmu: Don't pass KERN_ERR to pr_err
2018-06-26 16:47 [PATCH 1/1] tcmu: Don't pass KERN_ERR to pr_err Mike Christie
@ 2018-06-26 16:55 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2018-06-26 16:55 UTC (permalink / raw)
To: target-devel
Mike,
> Fix warning:
>
> smatch warnings:
> drivers/target/target_core_user.c:301 tcmu_genl_cmd_done() warn: KERN_*
> level not at start of string
Applied to 4.19/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-26 16:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-26 16:47 [PATCH 1/1] tcmu: Don't pass KERN_ERR to pr_err Mike Christie
2018-06-26 16:55 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).