From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Israel Rukshin <israelr@mellanox.com>
Cc: Target-devel <target-devel@vger.kernel.org>,
Linux-scsi <linux-scsi@vger.kernel.org>,
Max Gurtovoy <maxg@mellanox.com>,
Sagi Grimberg <sagi@grimberg.me>, Christoph Hellwig <hch@lst.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] scsi: target/iblock: Fix protection error with sectors greater than 512B
Date: Thu, 19 Dec 2019 23:51:02 +0000 [thread overview]
Message-ID: <yq1r20zan89.fsf@oracle.com> (raw)
In-Reply-To: <1576078562-15240-1-git-send-email-israelr@mellanox.com> (Israel Rukshin's message of "Wed, 11 Dec 2019 17:36:02 +0200")
Israel,
> The sector size of the block layer is 512 bytes, but integrity
> interval size might be different (in case of 4K block size of the
> media). At the initiator side the virtual start sector is the one that
> was originally submitted by the block layer (512 bytes) for the Reftag
> usage. The initiator converts the Reftag to integrity interval units
> and sends it to the target. So the target virtual start sector should
> be calculated at integrity interval units. prepare_fn() and
> complete_fn() don't remap correctly the Reftag when using incorrect
> units of the virtual start sector, which leads to the following
> protection error at the device:
Applied to 5.5/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2019-12-19 23:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 15:36 [PATCH] scsi: target/iblock: Fix protection error with sectors greater than 512B Israel Rukshin
2019-12-18 17:28 ` Sagi Grimberg
2019-12-19 23:51 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1r20zan89.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=hch@lst.de \
--cc=israelr@mellanox.com \
--cc=linux-scsi@vger.kernel.org \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox